Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Sessions will now sync with the server at the start of every 5 waves #4808

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

frutescens
Copy link
Collaborator

@frutescens frutescens commented Nov 6, 2024

What are the changes the user will see?

None, ideally.

Why am I making these changes?

Requested.

What are the changes from a developer perspective?

The updateAll function call found in encounter-phase had a conditional to determine whether the game should sync to the server or not. The modulo used to use 10; now it uses 5.
Sessions should now save on wave 1, X6, and X11.

How to test the changes?

  1. Play 5 waves.
  2. Change devices when starting a new wave.
  3. New device should have progress up to the 6th wave.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)

@frutescens frutescens added Miscellaneous Changes that don't fit under any other label Lead Dev Review Lead Dev Review is required labels Nov 6, 2024
@frutescens frutescens requested a review from a team as a code owner November 6, 2024 23:07
@frutescens frutescens changed the title [Dev] Sessions will now sync with the server at the start of every wave [Dev] Sessions will now sync with the server at the start of every 5 waves Nov 6, 2024
MokaStitcher
MokaStitcher previously approved these changes Nov 10, 2024
Copy link
Collaborator

@MokaStitcher MokaStitcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but we should be waiting on Walker's / Pancakes' final go-ahead before merging

DayKev
DayKev previously approved these changes Nov 16, 2024
@frutescens frutescens dismissed stale reviews from DayKev and MokaStitcher via 08f763f November 16, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead Dev Review Lead Dev Review is required Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants