[Ability] Implement Wimp Out and Emergency Exit

[muscode13]

What are the changes the user will see?

Wimp Out and Emergency Exit implemented

Why am I making these changes?

Ability is not implemented

What are the changes from a developer perspective?

There are several attributes and a condition function, as well as some helper functions I added to make this ability work:

• calculateShellBellRecovery - Calculates the amount healed off Shell Bell. This covers the case where if the pokemon's health falls below half and recovers back above half from a Shell Bell, Wimp Out should activate even after the Shell Bell recovery
• ForceSwitchOutHelper - This is mostly logic from the ForceSwitchOutAttr in moves that was lifted and shifted here.
• PostDamageAbAttr - This ability attribute triggers after the pokemon takes damage.
• PostDamageForceSwitchAbAttr - This triggers a forced switch out after the pokemon drops below the given ratio, defaulting at 50%, it has several conditions like certain moves not triggering it like Pain Split or if it falls below half and recovers back above half from a Shell Bell, it will activate even after the Shell Bell recovery

I also had to add a small check and helper function to PostDamageForceSwitchAbAttr in moves.ts, to account for an edge case interaction: If Wimp Out activates due to being hit by U-turn or Volt Switch, the user of that move will not be switched out.

Videos

Hazard Activation (Stealth Rocks):

hazards.mp4

Recoil Activation:

recoil.mp4

Post Defend Activation:

defending.mp4

Weather Activation (Hail):

weather.mp4

Post Turn Damage Activation (Leech Seed):

postturn.mp4

Victory Activation (Aftermath):

aftermath.mp4

Ignore Trapped to Flee:

trapped.mp4

Substitute does not trigger Ability:

substitute.mp4

Wild Battle:

wild.mp4

Trainer Battle:

trainer.mp4

Vortex Trap (Whirlpool):

trap.mp4

Sky Drop Interaction:

skydrop.mp4

Sheer Force Interaction:

sheerforce.mp4

Multi-Hit moves continue uninterrupted:

multihit.mp4

U-Turn/Volt Switch interaction:

voltswitch.mp4

Does not Trigger when below half:

belowhalf.mp4

Status Damage:

toxic.mp4

Status Applied to Wimp Out user as they switch:

applystatus.mp4

If it falls below half and recovers back above half from a Shell Bell, Wimp Out will activate even after the Shell Bell recovery:

shellbell.mp4

Updated Multi Hit Move:

multihit.mp4

Multi Lens moves continue uninterrupted and triggers Ability:

multilens.mp4

Parental Bond continues uninterrupted and triggers Ability:

pbond.mp4

How to test the changes?

• Use Pokemon with Wimp Out in the game. If you want to test out a specific interaction, you can override and give the enemy pokemon a certain move, like Stealth Rock or Leech Seed.
• run npm run test wimp_out

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR? - The other PR has been closed for several months
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[flx-sta]

@muscode13 Thank you for your contribution.
Please make sure to provide some videos/screenshots of in-game footage for these implementations

[muscode13]

Hey! @flx-sta Added some videos. Let me know if you'd like some more!

Also just added the nightmare interaction following its recent bug fix

[innerthunder]

I feel like this can all be condensed into a single attribute if applied in Pokemon.damage, which covers every source of damage and is where the Pokemon's HP is actually updated. A new subset of ability attributes (say, PostDamageAbAttr) and a new apply function applyPostDamageAbAttrs in support of Wimp Out/EE's attribute could also be helpful.

[muscode13]

@innerthunder Refactored the code to now use a new class PostDamageAbAttr as suggested. The ability attributes have been cut down to just PostDamageForceSwitchAttr, which covers damage during all phases. I'll add some new videos later tonight.

[muscode13]

Alright! I updated the videos. They are all of the refactored version. Ready for another review

[innerthunder]

Just one nit left on my end

[muscode13]

@DayKev Added some code for Multi-Lens, but it's pretty ghetto since the modifier doesn't update the turnData with all the damage dealt. Let me know if you think we're better off without it. Thanks!

[muscode13]

Added 3 more videos to the description showing the updated Multi Hit, Multi Lens, and P Bond interaction