Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Localization] New translations batch locales (Move-disabling effects, abilities triggers, error messages) #4046

Closed
wants to merge 59 commits into from
Closed

[Localization] New translations batch locales (Move-disabling effects, abilities triggers, error messages) #4046

wants to merge 59 commits into from

Conversation

Adri1
Copy link
Contributor

@Adri1 Adri1 commented Sep 5, 2024 •
edited
Loading

What are the changes the user will see?

Added missing translations to locales (Move-disabling effects, abilities triggers, error messages)
I added English placeholders to facilitate suggestions, but if a language never provide any translation, I'll remove these placeholders before merge.

Why am I making these changes?

Having them translated

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?

@Adri1 Adri1 added the Localization Provides or updates translation efforts label Sep 5, 2024
@Adri1 Adri1 requested review from a team as code owners September 5, 2024 10:38
@Adri1 Adri1 changed the title [Localization] Move-disabling effects locales [Localization] Missing translations batch locales (Move-disabling effects, abilities triggers, error messages) Sep 6, 2024
@Adri1 Adri1 changed the title [Localization] Missing translations batch locales (Move-disabling effects, abilities triggers, error messages) [Localization] New translations batch locales (Move-disabling effects, abilities triggers, error messages) Sep 6, 2024
KimJeongSun
KimJeongSun requested changes Sep 6, 2024
View reviewed changes
src/locales/ko/ability-trigger.json Outdated Show resolved Hide resolved
src/locales/ko/ability-trigger.json Outdated Show resolved Hide resolved
src/locales/ko/menu.json Outdated Show resolved Hide resolved
src/locales/ko/menu.json Outdated Show resolved Hide resolved
@Adri1 Adri1 closed this Sep 6, 2024
@Adri1 Adri1 deleted the move-disabling-effects-locales branch September 6, 2024 16:02
DanStevensonx
DanStevensonx reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@DanStevensonx DanStevensonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translated from Poké Corpus to Spanish, had to change line 72 from the original Poke Corpus lines since it didnt specify the move name

src/locales/es/ability-trigger.json Show resolved Hide resolved
src/locales/es/ability-trigger.json Show resolved Hide resolved
src/locales/es/menu.json Show resolved Hide resolved
src/locales/es/menu.json Show resolved Hide resolved
src/locales/es/battler-tags.json Show resolved Hide resolved
src/locales/es/battler-tags.json Show resolved Hide resolved
src/locales/es/battle.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanStevensonx DanStevensonx DanStevensonx left review comments

@sodaMelon sodaMelon sodaMelon left review comments

@CodeTappert CodeTappert CodeTappert left review comments

@KimJeongSun KimJeongSun KimJeongSun requested changes

@NicusPulcis NicusPulcis NicusPulcis left review comments

Assignees
No one assigned
Labels
Localization Provides or updates translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Adri1 @CodeTappert @KimJeongSun @sodaMelon @DanStevensonx @NicusPulcis