[QoL] Allow Own Tempo Rockruff to spawn in the wild. #2782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flx-sta
added
(Legacy) Bug
|
Just asking if this is planned to be merged anytime soon? really want to use dusk lycanroc :) |
Disclaimers
chore: Update TNC links layout and position in index.html
there were concerns from the dev team that this would shoehorn too many wild rockruffs into being dusk form, so I need to learn how to lower the chance of own tempo form |
swap dusk form lycanroc to be formindex 1, so that when you catch a dusk lycanroc you get own tempo rockruff
Removes Lycanroc's forms from being a time of day based when spawning in the wild(and in trainers parties!), and instead make it based on a % chance for each form, with each form being the same BST I think it hardly matters which one you find personally. Also sets Own Tempo Rockruff to be a 20% chance to spawn when a Rockruff is generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
Adds Rockruff to battle-scene.ts in the section for wild pokemon form spawns, assume it's an oversight that it's not there at all due to Own Tempo's original implementation(it didn't work and wasn't a form previously).
This will give any Rockruff that spawns a 50/50 chance to have Own Tempo form, I don't see this as being much of a buff, as Froakie and it's line have the same logic for Battle Bond, which is arguably a much better ability and pokemon combo.
Arguably, for "balance", this could be changed to be a 1/3 chance instead, if the balance team would rather have that, that's easily doable I think?
Why am I doing these changes?
Currently, own tempo form was locked to finding a lycanroc that had the form, which is a little obtuse, since a dusk form lycanroc can currently spawn without having the form.
What did change?
Added one line to battle-scene.ts, line 1225.
Screenshots/Videos
How to test the changes?
Set your enemy's pokemon species in overrides to be rockruff
catch some rockruffs
some of them have own tempo! yay!
Checklist
npm run test)