Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprite] Shiny Spritzee colour correction #2781

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

chaosgrimmon
Copy link
Collaborator

@chaosgrimmon chaosgrimmon commented Jul 3, 2024

What are the changes?

Only one frame of shiny Spritzee's sprite was the correct colour. This PR fixes that, and cleans up the palettes in general.

Why am I doing these changes?

Previously reported.
image
image

What did change?

The shiny sprite's palette was cleaned up, removing the old, incorrect colours. As a preemptive measure, the same cleanup was performed on the non-shiny sprite, in preparation for future variants.

Screenshots/Videos

Before

image

After

image

How to test the changes?

As the issue only concerned front experimental animations, the change can be seen on any sufficiently-completed savefile.

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@flx-sta flx-sta added the (Legacy) Bug Legacy Label, don't apply to new issues/PRs label Jul 4, 2024
@Tempo-anon Tempo-anon merged commit 38ed57f into pagefaultgames:main Jul 4, 2024
5 checks passed
@chaosgrimmon chaosgrimmon deleted the exp-spritzee branch July 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Legacy) Bug Legacy Label, don't apply to new issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants