[Challenge] Eevee only challenge #2753

hayuna · 2024-07-02T08:49:15Z

What are the changes?

Add new challenge mode

Why am I doing these changes?

Make challenge more interesting

What did change?

Added new option in challenge
Allow to use only Eevee
Allow to use duplicated species
Not allow to use other pokemon than Eeveelutions

Screenshots/Videos

New option in challenge menu

Allow to use only Eevee

Allow to have duplicated species

Cannot use other pokemon than Eevee

Completed challenge

How to test the changes?

Choose new challenge

Checklist

There is no overlap with another PR?
The PR is self-contained and cannot be split into smaller PRs?
Have I provided a clear explanation of the changes?
Have I tested the changes (manually)?
- Are all unit tests still passing? (npm run test)
Are the changes visual?
- Have I provided screenshots/videos of the changes?

feat: Add link to Discord in menu UI feat: Add Discord and Google login functionality Add container around discord and google icons refactor: Update environment variable names for Discord and Google client IDs feat: Add "Or use" translation for login options in multiple languages feat: Update menu UI translations for multiple languages Code review fixes refactor: Update Discord and Google client IDs in environment variables

Co-authored-by: Jannik Tappert <[email protected]>

this also reduces output noise in tests

hayuna · 2024-07-02T09:03:06Z

Seems like this test is flaky, sometimes is working, sometimes fail

src/test/abilities/costar.test.ts > Abilities - COSTAR > ability copies positive stat changes

another run of tests (passed)

src/locales/ko/challenges.ts

src/locales/ko/achv.ts

sodaMelon

Really cool the "Eevee only challenge"
i added korean localization.

+)Oh, that's applied lol LGTM

src/locales/de/achv.ts

src/locales/de/challenges.ts

CodeTappert · 2024-07-02T10:53:49Z

If Eveelutions are allowed then the description should reflect this.
Also make the "On" and "Off" seperate entries in that file. So it can be easier resued later by other challenges

RimKnight

Add cn translation

src/locales/zh_CN/challenges.ts

src/locales/zh_CN/achv.ts

hayuna · 2024-07-02T11:05:39Z

Moved On/Off to the top of translations
Changed description to be more descriptive with evolutions of Eevee

src/locales/pt_BR/achv.ts

src/locales/pt_BR/challenges.ts

src/locales/ko/challenges.ts

Adri1

Edited French (you can merge this edit direcly from this comment with the button on the bottom right of it, no copy-pasting needed)

src/locales/fr/challenges.ts

src/locales/pt_BR/challenges.ts

* add test for rollout move Co-authored-by: Zach Day <[email protected]> * fix tests still using `SINGLE_BATTLE_OVERRIDE` --------- Co-authored-by: Zach Day <[email protected]>

…es#3115) * Fix Hyper Beam, etc. permanently recharging * Fix override in hyper beam test

* update images for new UI * add updated starter UI with filter code * update starter-select test code * update win filter condition to pass test * remove unnecessary console log * update test code to match current filter UI * merge update * apply bugfix & chrry-pick small issues fix which are handled beta branch * resolve conflicts * fix lint errors * Fixed a bug where the target location for escaping using the left and right buttons on the starter button did not account for scrolling * update filter bar label color change when activated * fix lint error * fix lint * fix octolock.text.ts. it looks override import error. idk why it is happend in this PR. but it looks ok now * add passive dropdown in unlocks filter * fix lint * fix double button sound bug. refactoring genSpecies -> allSpecies, starterContainers -> starterContainer which are remove unnecessary generation axis * optimize updateStarterValueLabel function which is bottleneck of UI update latency * apply translation of gen filter label. fix lint * add # candies sort option * merge beta * resolve confilcts * fix offset of starter and start cursor * make compatible with starter UI * add missing feature * add images for legacy UI. adjust the position and size of the starterContainerWindow

* Implement Pokemon forms localization * Update French pokemon-form.ts * Update French pokemon-form.ts * Update pokemon-form.ts * Add battle forms korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add cosplay forms korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add pichu form korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add castform forms korean translation by returntoice Co-authored-by: returntoice <[email protected]> * Add remaining forms korean translation by returntoice Co-authored-by: returntoice <[email protected]> * French typo corrections pokemon-form.ts * Update Korean pokemon-form.ts * Modify froakiBattleBond like rockruff of OwnTempo case, it is froakie, not greninja. * Modify zygardePc Power construct is more important information Switch its position to 50% or 10% to avoid overlapping with the sprite * Modify mispelling * Added german forms * Changed Gigadynamax and Unendynamax so it fits at all * Add partner pikachu and eevee form localization * Add mimikyu forms localization * Partner Pikachu, Partner Evoli und Mimikyu Formen hinzugefügt * Update pokemon-form.ts * Update partners * Fix conflicts * Fix useless ? by flx-sta Co-authored-by: flx-sta <[email protected]> * Fix switch use by flx-sta * Fix conflicts * Please work !!!!!!! * Update src/locales/fr/pokemon-form.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/pokemon-form.ts Co-authored-by: Lugiad' <[email protected]> * Add pt_br primal localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br pikachu localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br castform localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br 3g localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add zh_cn localization Co-authored-by: Yonmaru40 <[email protected]> * Add pt_br other localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add es castform localization Co-authored-by: InnocentGameDev <[email protected]> * Add es burmy localization Co-authored-by: InnocentGameDev <[email protected]> * Add es shellos localization Co-authored-by: InnocentGameDev <[email protected]> * Add es rotom localization Co-authored-by: InnocentGameDev <[email protected]> * Add es basculin localization Co-authored-by: InnocentGameDev <[email protected]> * Add es deerling localization Co-authored-by: InnocentGameDev <[email protected]> * Add es froakie localization Co-authored-by: InnocentGameDev <[email protected]> * Add es scatterbug localization Co-authored-by: InnocentGameDev <[email protected]> * Add es furfrou localization Co-authored-by: InnocentGameDev <[email protected]> * Add es xerneas localization Co-authored-by: InnocentGameDev <[email protected]> * Add es zygarde localization Co-authored-by: InnocentGameDev <[email protected]> * Add es pumpkaboo localization Co-authored-by: InnocentGameDev <[email protected]> * Add es flabebe localization Co-authored-by: InnocentGameDev <[email protected]> * Add es oricorio localization Co-authored-by: InnocentGameDev <[email protected]> * Add es minior localization Co-authored-by: InnocentGameDev <[email protected]> * Add es magearna localization Co-authored-by: InnocentGameDev <[email protected]> * Add es marshadow localization Co-authored-by: InnocentGameDev <[email protected]> * Add es sinistea ocalization Co-authored-by: InnocentGameDev <[email protected]> * Add es eiscue localization Co-authored-by: InnocentGameDev <[email protected]> * Add es indeedee localization Co-authored-by: InnocentGameDev <[email protected]> * Add es rockruff localization Co-authored-by: InnocentGameDev <[email protected]> * Add es mimikyu localization Co-authored-by: InnocentGameDev <[email protected]> * Add es zarude localization Co-authored-by: InnocentGameDev <[email protected]> * Add es squawkabilly localization Co-authored-by: InnocentGameDev <[email protected]> * Add es tatsugiri localization Co-authored-by: InnocentGameDev <[email protected]> * Add es gimmighoul localization Co-authored-by: InnocentGameDev <[email protected]> * Add es poltchageit localization Co-authored-by: InnocentGameDev <[email protected]> * Add es paldeaTauros localization Co-authored-by: InnocentGameDev <[email protected]> * Add es primal localization Co-authored-by: InnocentGameDev <[email protected]> * Add es pikachu localization Co-authored-by: InnocentGameDev <[email protected]> * Add es partner localization Co-authored-by: InnocentGameDev <[email protected]> * Fix typedocs error * Fix typedocs error * cn form prefix added Co-authored-by: Yonmaru40 <[email protected]> * Fix german translate error * Fix typo Zh_CN Co-authored-by: mercurius-00 <[email protected]> * Update pokemon-form.ts [Localization(it)] * Update src/locales/es/pokemon-form.ts Co-authored-by: InnocentGameDev <[email protected]> * Fix megas forms bug and add forgotten forms * Fix wrong ko config * Add fr localization for new forms Co-authored-by: Lugiad' <[email protected]> * Add de localization for new forms Co-authored-by: Jannik Tappert <[email protected]> * Remove forgotten debug line Co-authored-by: Jannik Tappert <[email protected]> * Optimize battle forms * Update pokemon-form.ts (additional forms, italian localization) * The same typo is in the zh_TW placeholder text too. Co-authored-by: Madmadness65 <[email protected]> * Fix forgotten megaY Co-authored-by: Jannik Tappert <[email protected]> * Add capitalizeString to utils * Fix typedoc error * Update src/data/pokemon-species.ts Co-authored-by: Jannik Tappert <[email protected]> * Add ko localization for new forms Co-authored-by: MrWaterT <[email protected]> --------- Co-authored-by: Lugiad <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: Mr.WaterT <[email protected]> Co-authored-by: MrWaterT <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: flx-sta <[email protected]> Co-authored-by: Benjamin Odom <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: InnocentGameDev <[email protected]> Co-authored-by: EnochG1 <[email protected]> Co-authored-by: mercurius-00 <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Madmadness65 <[email protected]>

…efaultgames#2785)

Fixes pagefaultgames#2982

…mes#2687)

…ultgames#3118) * Make on-summon abilities trigger after the switch check * Add test

Maintains parity with Air Lock. Both of these probably need to be localized. Should fix issue 491 though

* Option to view Summary before adding new Pokemon to party * Fixed issues described by HopsWas * Adjusted makeRoomForConfirmUi to improve window spacing * Fixed ESLint issue + addressed OrangeRed review * Fixed Github pages issue * Removed duplicate unshiftPhase * Fixed phase order * Don't start from beginning of catch function * Option to view Summary before adding new Pokemon to party * Fixed issues described by HopsWas * Adjusted makeRoomForConfirmUi to improve window spacing * Fixed Github pages issue * Fixed phase order * Quick fix * This should fix the summaryOption feature without bugging confirm-ui-handler in other cases * Revert "Merge remote-tracking branch 'origin/summaryOption1' into summaryOption1" This reverts commit ea7d0ce, reversing changes made to 4c56595. * Added a better conditional that reflects its source and purpose --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: AJ Fontaine <[email protected]>

…te disruption (pagefaultgames#3041) * Adds frenzyMissFunc trigger on NO_EFFECT hit result * Refactors FrenzyAttr to properly lapse tags each turn and remove tags on disrupt * Makes comment on CONFUSED tag clearer * Changes all integer usages to number in battler-tags * Update getBattlerTag function to use number instead of integer

* Bug Fix * Update src/system/game-stats.ts Co-authored-by: flx-sta <[email protected]> * Fixing a test * Fixed import * Revert "Bug Fix" This reverts commit 8348449. --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: flx-sta <[email protected]>

…eams (pagefaultgames#3124)

…ames#3122) * Bug Fix * Update src/system/game-stats.ts Co-authored-by: flx-sta <[email protected]> * Fixing a test * Revert "Fixing a test" This reverts commit 1bdbe2d. * Test Re-Run --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: flx-sta <[email protected]>

…ch and double battles (pagefaultgames#2462) * Adjust how counter attacks target to account for uturn/voltswitch * Creates move flag for metal burst/comeuppance to redirect in some cases * Remove debug printing * Bit shifts the redirect counter flag * Removes extraneous class from prior testing * Remove vitest timestamp file that was accidentally added

Mystic ticket icons in the achievements just confuse players

…red in dex (pagefaultgames#2713) * Fix reins et al being available without unlocking second mon * Small fix * Parentheses for safety * Add documentation to new function

Co-authored-by: Frutescens <info@laptop>

CodeTappert · 2024-07-24T22:41:35Z

Please fix conflicts

…stats (pagefaultgames#3117) * Fixed OHKO moves being affected by accuracy and evasion battle stats * Added related tests for Fissure, unskipped related test for Hustle * Tweaked fissure accuracy and evasion tests to use spyOn() for getAccuracyMultiplier() as per feedback * Fixed accuracy test for Fissure

* [Fix][Sprite] Politoed Back Sprites Retrieved first version from history. Rearranged frames to make jump a little less floaty. Set same anim length for all variations. Json is identical for all variations. Spritesheet frame position is identical for all variations. Trimmed the frame of extra space Reduced file size of spritesheets and JSON due to less unique frames needed. * [Fix][Sprite] Politoed Back Sprites - Reformatted JSON to texturepacker standard Reformatted json.

* fix remove pokemon menu * fix dropdown all is not changing bug * fix bug when go down with no starter on start button * fix starter corsor bug on deletion. out of screen cursor bug * fix challenge log * fix lint error

hayuna · 2024-08-02T16:46:51Z

New PR

#3305

f-fsantos and others added 7 commits June 19, 2024 17:31

refactor: Add missing properties to initLoggedInUser function

dbb1fc1

Update src/locales/de/menu-ui-handler.ts

ef5847d

Co-authored-by: Jannik Tappert <[email protected]>

make i18n debugging an optional env setting

782718c

this also reduces output noise in tests

set development default also to "0"

e929538

Add challenge to use only Eevee

cac7e6d

Add challenge to use only Eevee

9e60b12

hayuna marked this pull request as draft July 2, 2024 08:49

This comment was marked as resolved.

Sign in to view

Add fr locales

0ace205

sodaMelon reviewed Jul 2, 2024

View reviewed changes

src/locales/ko/challenges.ts Outdated Show resolved Hide resolved

Add ko challenges locales

177271c

sodaMelon reviewed Jul 2, 2024

View reviewed changes

src/locales/ko/achv.ts Outdated Show resolved Hide resolved

Add ko achv locales

71c57d6

sodaMelon reviewed Jul 2, 2024

View reviewed changes

CodeTappert reviewed Jul 2, 2024

View reviewed changes

src/locales/de/achv.ts Outdated Show resolved Hide resolved

CodeTappert reviewed Jul 2, 2024

View reviewed changes

src/locales/de/challenges.ts Outdated Show resolved Hide resolved

Add de locales

124865c

RimKnight reviewed Jul 2, 2024

View reviewed changes

src/locales/zh_CN/challenges.ts Outdated Show resolved Hide resolved

src/locales/zh_CN/achv.ts Outdated Show resolved Hide resolved

hayuna added 3 commits July 2, 2024 12:55

Add cn locales

99f5b9b

Changed challenge description to respect evolutions

206da58

Move On/Off outside specific challenge

cdf8769

josericardo-fo reviewed Jul 2, 2024

View reviewed changes

src/locales/pt_BR/achv.ts Outdated Show resolved Hide resolved

josericardo-fo reviewed Jul 2, 2024

View reviewed changes

src/locales/pt_BR/challenges.ts Outdated Show resolved Hide resolved

sodaMelon reviewed Jul 2, 2024

View reviewed changes

src/locales/ko/challenges.ts Outdated Show resolved Hide resolved

Adri1 reviewed Jul 2, 2024

View reviewed changes

src/locales/fr/challenges.ts Outdated Show resolved Hide resolved

josericardo-fo reviewed Jul 2, 2024

View reviewed changes

src/locales/pt_BR/challenges.ts Outdated Show resolved Hide resolved

flx-sta and others added 19 commits July 24, 2024 00:46

[Test] Add test for rollout move (pagefaultgames#3114)

1563b8e

* add test for rollout move Co-authored-by: Zach Day <[email protected]> * fix tests still using `SINGLE_BATTLE_OVERRIDE` --------- Co-authored-by: Zach Day <[email protected]>

[Bug][Beta] Fix Hyper Beam, etc. permanently recharging (pagefaultgam…

9c80e6d

…es#3115) * Fix Hyper Beam, etc. permanently recharging * Fix override in hyper beam test

[Move] Fully implement Jungle Healing/Lunar Blessing status heal (pag…

0ba8959

…efaultgames#2785)

[Bug] Fix tags not resetting on switch (pagefaultgames#3119)

d1e1879

Fixes pagefaultgames#2982

[Move] Water Shuriken guarantees 3 hits with battle bond (pagefaultga…

79e2b12

…mes#2687)

[Bug] Make on-summon abilities trigger after the switch check (pagefa…

5111c91

…ultgames#3118) * Make on-summon abilities trigger after the switch check * Add test

[Ability] Cloud Nine now displays a message on activation

3f9f791

Maintains parity with Air Lock. Both of these probably need to be localized. Should fix issue 491 though

[Bug] Fix HP rounding issues (pagefaultgames#2968)

a526403

[Localization] Correctly Localized German names of the BGM for Evil T…

f3a98ef

…eams (pagefaultgames#3124)

[Misc] Change fresh start achievement icon to reviver seed

3caa51b

Mystic ticket icons in the achievements just confuse players

[Balance] Fix N-Solarizer etc appearing without secondary mon registe…

64d9c11

…red in dex (pagefaultgames#2713) * Fix reins et al being available without unlocking second mon * Small fix * Parentheses for safety * Add documentation to new function

Bug Fix (pagefaultgames#3129)

45d9c65

Co-authored-by: Frutescens <info@laptop>

Corrade and others added 6 commits July 24, 2024 20:34

[Bug] fix and condition of shiny and passive (pagefaultgames#3136)

29a5dd0

Merge branch 'beta' into eevee-challenge

e63cb84

Update starter-select-ui-handler.ts

3351381

f-fsantos force-pushed the beta branch from 4bfa0e6 to 8a883ea Compare July 28, 2024 16:32

flx-sta added the Challenges Challenge mode/s related label Aug 2, 2024

hayuna closed this Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Challenge] Eevee only challenge #2753

[Challenge] Eevee only challenge #2753

hayuna commented Jul 2, 2024 •

edited

Loading

hayuna commented Jul 2, 2024 •

edited

Loading

This comment was marked as resolved.

sodaMelon left a comment •

edited

Loading

CodeTappert commented Jul 2, 2024 •

edited

Loading

RimKnight left a comment

hayuna commented Jul 2, 2024

Adri1 left a comment

CodeTappert commented Jul 24, 2024

hayuna commented Aug 2, 2024

[Challenge] Eevee only challenge #2753

[Challenge] Eevee only challenge #2753

Conversation

hayuna commented Jul 2, 2024 • edited Loading

What are the changes?

Why am I doing these changes?

What did change?

Screenshots/Videos

How to test the changes?

Checklist

hayuna commented Jul 2, 2024 • edited Loading

This comment was marked as resolved.

sodaMelon left a comment • edited Loading

Choose a reason for hiding this comment

CodeTappert commented Jul 2, 2024 • edited Loading

RimKnight left a comment

Choose a reason for hiding this comment

hayuna commented Jul 2, 2024

Adri1 left a comment

Choose a reason for hiding this comment

CodeTappert commented Jul 24, 2024

hayuna commented Aug 2, 2024

hayuna commented Jul 2, 2024 •

edited

Loading

hayuna commented Jul 2, 2024 •

edited

Loading

sodaMelon left a comment •

edited

Loading

CodeTappert commented Jul 2, 2024 •

edited

Loading