Skip to content

Commit

Permalink
[Refactor] Remove obsolete comments in egg gacha and starter select U…
Browse files Browse the repository at this point in the history
…Is (#4542)
  • Loading branch information
DayKev authored Oct 2, 2024
1 parent c46507d commit a6bcd6e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/ui/egg-gacha-ui-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { VoucherType, getVoucherTypeIcon } from "../system/voucher";
import { getPokemonSpecies } from "../data/pokemon-species";
import { addWindow } from "./ui-theme";
import { Tutorial, handleTutorial } from "../tutorial";
import {Button} from "#enums/buttons";
import { Button } from "#enums/buttons";
import Overrides from "#app/overrides";
import { GachaType } from "#app/enums/gacha-types";
import i18next from "i18next";
Expand Down Expand Up @@ -99,7 +99,7 @@ export default class EggGachaUiHandler extends MessageUiHandler {

const gachaInfoContainer = this.scene.add.container(160, 46);

const currentLanguage = i18next.resolvedLanguage!; // TODO: is this bang correct?
const currentLanguage = i18next.resolvedLanguage ?? "en";
let gachaTextStyle = TextStyle.WINDOW_ALT;
let gachaX = 4;
let gachaY = 0;
Expand Down Expand Up @@ -217,7 +217,7 @@ export default class EggGachaUiHandler extends MessageUiHandler {
{ multiplier: multiplierOne, description: `25 ${i18next.t("egg:pulls")}`, icon: getVoucherTypeIcon(VoucherType.GOLDEN) }
];

const resolvedLanguage = i18next.resolvedLanguage ?? "en"; // TODO: is this bang correct?
const resolvedLanguage = i18next.resolvedLanguage ?? "en";
const pullOptionsText = pullOptions.map(option =>{
const desc = option.description.split(" ");
if (desc[0].length < 2) {
Expand Down
4 changes: 2 additions & 2 deletions src/ui/starter-select-ui-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@ export default class StarterSelectUiHandler extends MessageUiHandler {

setup() {
const ui = this.getUi();
const currentLanguage = i18next.resolvedLanguage ?? "en"; // TODO: is this bang correct?
const langSettingKey = Object.keys(languageSettings).find(lang => currentLanguage.includes(lang)) ?? "en"; // TODO: is this bang correct?
const currentLanguage = i18next.resolvedLanguage ?? "en";
const langSettingKey = Object.keys(languageSettings).find(lang => currentLanguage.includes(lang)) ?? "en";
const textSettings = languageSettings[langSettingKey];

this.starterSelectContainer = this.scene.add.container(0, -this.scene.game.canvas.height / 6);
Expand Down

0 comments on commit a6bcd6e

Please sign in to comment.