Skip to content

Commit

Permalink
[Bug] Fix description of rare candy to have proper amount of level (#…
Browse files Browse the repository at this point in the history
…2903)

* [Bug] Fix description of rare candy to have proper amount of level

* Update en locales

* Add locales

* Add locales

* Update src/locales/de/modifier-type.ts

Co-authored-by: Jannik Tappert <[email protected]>

* Update src/locales/de/modifier-type.ts

Co-authored-by: Jannik Tappert <[email protected]>

* Update src/locales/fr/modifier-type.ts

Co-authored-by: Lugiad' <[email protected]>

* Update src/locales/fr/modifier-type.ts

Co-authored-by: Lugiad' <[email protected]>

* Update src/locales/ko/modifier-type.ts

Co-authored-by: Enoch <[email protected]>

* Update src/locales/ko/modifier-type.ts

Co-authored-by: Enoch <[email protected]>

* Update src/locales/zh_CN/modifier-type.ts

Co-authored-by: Yonmaru40 <[email protected]>

* Update src/locales/zh_CN/modifier-type.ts

Co-authored-by: Yonmaru40 <[email protected]>

* Update src/locales/pt_BR/modifier-type.ts

Co-authored-by: José Ricardo Fleury Oliveira <[email protected]>

* Update src/locales/pt_BR/modifier-type.ts

Co-authored-by: José Ricardo Fleury Oliveira <[email protected]>

* Update modifier-type.ts (IT)

* Update src/locales/es/modifier-type.ts

Co-authored-by: Arxxer <[email protected]>

* Update src/locales/es/modifier-type.ts

Co-authored-by: Arxxer <[email protected]>

---------

Co-authored-by: Jannik Tappert <[email protected]>
Co-authored-by: Lugiad' <[email protected]>
Co-authored-by: Enoch <[email protected]>
Co-authored-by: Yonmaru40 <[email protected]>
Co-authored-by: José Ricardo Fleury Oliveira <[email protected]>
Co-authored-by: Niccolò <[email protected]>
Co-authored-by: Arxxer <[email protected]>
  • Loading branch information
8 people authored Jul 12, 2024
1 parent 39bdfea commit 3a1d41a
Show file tree
Hide file tree
Showing 10 changed files with 30 additions and 20 deletions.
4 changes: 2 additions & 2 deletions src/locales/de/modifier-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ export const modifierType: ModifierTypeTranslationEntries = {
description: "Erhöht die Stärke aller {{moveType}}-Attacken eines Pokémon um 20%.",
},
"PokemonLevelIncrementModifierType": {
description: "Erhöht das Level eines Pokémon um 1.",
description: "Erhöht das Level eines Pokémon um {{levels}}.",
},
"AllPokemonLevelIncrementModifierType": {
description: "Erhöht das Level aller Teammitglieder um 1.",
description: "Erhöht das Level aller Teammitglieder um {{levels}}.",
},
"PokemonBaseStatBoosterModifierType": {
description: "Erhöht den {{statName}} Basiswert des Trägers um 10%. Das Stapellimit erhöht sich, je höher dein IS-Wert ist.",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/en/modifier-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ export const modifierType: ModifierTypeTranslationEntries = {
description: "Increases the power of a Pokémon's {{moveType}}-type moves by 20%.",
},
"PokemonLevelIncrementModifierType": {
description: "Increases a Pokémon's level by 1.",
description: "Increases a Pokémon's level by {{levels}}.",
},
"AllPokemonLevelIncrementModifierType": {
description: "Increases all party members' level by 1.",
description: "Increases all party members' level by {{levels}}.",
},
"PokemonBaseStatBoosterModifierType": {
description: "Increases the holder's base {{statName}} by 10%. The higher your IVs, the higher the stack limit.",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/es/modifier-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ export const modifierType: ModifierTypeTranslationEntries = {
description: "Aumenta la potencia de los movimientos de tipo {{moveType}} de un Pokémon en un 20%.",
},
"PokemonLevelIncrementModifierType": {
description: "Aumenta el nivel de un Pokémon en 1.",
description: "Aumenta el nivel de un Pokémon en {{levels}}.",
},
"AllPokemonLevelIncrementModifierType": {
description: "Aumenta el nivel de todos los miembros del equipo en 1.",
description: "Aumenta el nivel de todos los miembros del equipo en {{levels}}.",
},
"PokemonBaseStatBoosterModifierType": {
description: "Aumenta la est. {{statName}} base del portador en un 10%.\nCuanto mayores sean tus IVs, mayor será el límite de acumulación.",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/fr/modifier-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ export const modifierType: ModifierTypeTranslationEntries = {
description: "Augmente de 20% la puissance des capacités de type {{moveType}} d’un Pokémon.",
},
"PokemonLevelIncrementModifierType": {
description: "Fait monter un Pokémon d’un niveau.",
description: "Fait monter un Pokémon de {{levels}} niveau·x.",
},
"AllPokemonLevelIncrementModifierType": {
description: "Fait monter toute l’équipe d’un niveau.",
description: "Fait monter toute l’équipe de {{levels}} niveau·x.",
},
"PokemonBaseStatBoosterModifierType": {
description: "Augmente de 10% {{statName}} de base de son porteur. Plus les IV sont hauts, plus il peut en porter.",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/it/modifier-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ export const modifierType: ModifierTypeTranslationEntries = {
description: "Aumenta la potenza delle mosse di tipo {{moveType}} del 20% per un Pokémon.",
},
"PokemonLevelIncrementModifierType": {
description: "Fa salire un Pokémon di un livello.",
description: "Aumenta il livello di un Pokémon di {{levels}}.",
},
"AllPokemonLevelIncrementModifierType": {
description: "Aumenta il livello di tutti i Pokémon nel gruppo di 1.",
description: "Aumenta i livell di tutti i Pokémon della squadra di {{levels}}.",
},
"PokemonBaseStatBoosterModifierType": {
description: "Aumenta {{statName}} di base del possessore del 10%.",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/ko/modifier-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ export const modifierType: ModifierTypeTranslationEntries = {
description: "지니게 하면 {{moveType}}타입 기술의 위력이 20% 상승한다.",
},
"PokemonLevelIncrementModifierType": {
description: "포켓몬 1마리의 레벨이 1만큼 상승한다.",
description: "포켓몬 1마리의 레벨이 기본 1만큼, 사탕단지의 개수에 따라 최대 {{levels}}까지 상승한다.",
},
"AllPokemonLevelIncrementModifierType": {
description: "자신의 모든 포켓몬의 레벨이 1씩 상승한다.",
description: "자신의 모든 포켓몬의 레벨이 기본 1씩, 사탕단지의 개수에 따라 최대 {{levels}}까지 상승한다.",
},
"PokemonBaseStatBoosterModifierType": {
description: "지니게 하면 {{statName}} 종족값을 10% 올려준다. 개체값이 높을수록 더 많이 누적시킬 수 있다.",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/pt_BR/modifier-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ export const modifierType: ModifierTypeTranslationEntries = {
description: "Aumenta o poder dos ataques do tipo {{moveType}} de um Pokémon em 20%.",
},
"PokemonLevelIncrementModifierType": {
description: "Aumenta em 1 o nível de um Pokémon.",
description: "Aumenta em {{levels}} o nível de um Pokémon.",
},
"AllPokemonLevelIncrementModifierType": {
description: "Aumenta em 1 os níveis de todos os Pokémon.",
description: "Aumenta em {{levels}} o nível de todos os membros da equipe.",
},
"PokemonBaseStatBoosterModifierType": {
description: "Aumenta o atributo base de {{statName}} em 10%. Quanto maior os IVs, maior o limite de aumento.",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/zh_CN/modifier-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ export const modifierType: ModifierTypeTranslationEntries = {
description: "一只宝可梦的{{moveType}}系招式威力提升20%。",
},
"PokemonLevelIncrementModifierType": {
description: "一只宝可梦等级提升1级。",
description: "使一只宝可梦的等级提升{{levels}}级。",
},
"AllPokemonLevelIncrementModifierType": {
description: "所有成员宝可梦等级提升1级。",
description: "使一只寶可夢的等級提升{{levels}}級。",
},
"PokemonBaseStatBoosterModifierType": {
description: "增加10%持有者的{{statName}},\n个体值越高堆叠上限越高。",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/zh_TW/modifier-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ export const modifierType: ModifierTypeTranslationEntries = {
description: "一隻寶可夢的{{moveType}}系招式威力提升20%。",
},
PokemonLevelIncrementModifierType: {
description: "一隻寶可夢等級提升1級。",
description: "Increases a Pokémon's level by {{levels}}.",
},
AllPokemonLevelIncrementModifierType: {
description: "所有成員寶可夢等級提升1級。",
description: "Increases all party members' level by {{levels}}.",
},
PokemonBaseStatBoosterModifierType: {
description:
Expand Down
14 changes: 12 additions & 2 deletions src/modifier/modifier-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,12 @@ export class PokemonLevelIncrementModifierType extends PokemonModifierType {
}

getDescription(scene: BattleScene): string {
return i18next.t("modifierType:ModifierType.PokemonLevelIncrementModifierType.description");
let levels = 1;
const hasCandyJar = scene.modifiers.find(modifier => modifier instanceof Modifiers.LevelIncrementBoosterModifier);
if (hasCandyJar) {
levels += hasCandyJar.stackCount;
}
return i18next.t("modifierType:ModifierType.PokemonLevelIncrementModifierType.description", {levels });
}
}

Expand All @@ -576,7 +581,12 @@ export class AllPokemonLevelIncrementModifierType extends ModifierType {
}

getDescription(scene: BattleScene): string {
return i18next.t("modifierType:ModifierType.AllPokemonLevelIncrementModifierType.description");
let levels = 1;
const hasCandyJar = scene.modifiers.find(modifier => modifier instanceof Modifiers.LevelIncrementBoosterModifier);
if (hasCandyJar) {
levels += hasCandyJar.stackCount;
}
return i18next.t("modifierType:ModifierType.AllPokemonLevelIncrementModifierType.description", { levels });
}
}

Expand Down

0 comments on commit 3a1d41a

Please sign in to comment.