Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pact-go v1 to use latest pact-ruby-standalone (ruby 3.2 + arm64 support) #304

Merged
merged 7 commits into from
Jul 18, 2023

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Jul 11, 2023

as per #290 but retargeted against v1.x.x branch


Changes to traveling ruby to support additional platforms

Details of changes made to travelling ruby

PR's to Travelling ruby to update the supported archs

Which means we can now support

OS Ruby Architecture Supported
OSX 3.2.2 x86_64
OSX 3.2.2 aarch64 (arm)
Linux 3.2.2 x86_64
Linux 3.2.2 aarch64 (arm)
Windows 3.2.2 x86_64
Windows 3.2.2 x86
Windows 3.2.2 aarch64 (via x86 emulation)

Details of changes made to pact-ruby-standalone

Details of changes made to pact-go

These have been consumed in the pact-go project, and tested cross platform

In order to test ARM64 on MacOS, and Linux, I have utilised cirrus-ci, which is free for open-source usage (within reasonable limits)

OS Standalone Version Architecture Tested
OSX v2.0.3 x86_64 GitHub Actions
OSX v2.0.3 aarch64 (arm) Cirrus CI
Linux v2.0.3 x86_64 GitHub Actions
Linux v2.0.3 aarch64 (arm) Cirrus-CI
Windows v2.0.3 x86_64 untested
Windows v2.0.3 aarch64 (via x86 emulation) untested
Windows v2.0.3 x86 untested

User facing notes

  • Linux
  • Adds support for arm64
  • Drops support for x86 Linux
  • Adds support for macos arm64
    • macOS arm64 (m1/m2) users will no require require installing rosetta
  • Windows
    • i386 and x86_64 builds available

@coveralls
Copy link

coveralls commented Jul 11, 2023

Coverage Status

coverage: 77.52%. remained the same when pulling 852836e on YOU54F:test/pact-2.0.1 into 1668622 on pact-foundation:v1.x.x.

@YOU54F YOU54F changed the title Test/pact 2.0.1 Update pact-go v1 to use latest pact-ruby-standalone (ruby 3.2 + arm64 support) Jul 11, 2023
@mefellows
Copy link
Member

Nice! Thanks.

Looking at the commits, nothing would appear in the changelog. Is there a way to rebase and update a commit to add a feat?

In this package, I usually go for a feat: update to standalone x.y.z

- Supports ARM64 MacOS / Linux
- Drops support for 32bit Linux
- Adds support for 32bit / 64bt Windows
- Add CI tests for ARM64 MacOS / Linux
@YOU54F
Copy link
Member Author

YOU54F commented Jul 12, 2023

np makes total sense, have done that but just yak shaving some things whilst I am here - will poss split these out into sep PR's

@mefellows mefellows merged commit c4aa28e into pact-foundation:v1.x.x Jul 18, 2023
6 of 12 checks passed
@YOU54F YOU54F deleted the test/pact-2.0.1 branch October 3, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants