Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/improvements #350

Merged
merged 3 commits into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/PULL_REQUEST_TEMPLATE.md

This file was deleted.

15 changes: 15 additions & 0 deletions .github/workflows/check-release-notes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Check release notes

on:
pull_request:
types:
- opened
- edited
- synchronize

jobs:
check_release_notes:
name: Notes are either written, or there are none
uses: packit/.github/.github/workflows/check-release-notes.yml@main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be:

Suggested change
uses: packit/.github/.github/workflows/check-release-notes.yml@main
uses: packit/.github/workflows/check-release-notes.yml@main

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be that, but it screws up the path deduction, cause you can have the action in the repo, but also reuse it from other of your repos… so I had to move it there :/

It's this path:
https://github.com/packit/.github/blob/main/.github/workflows/check-release-notes.yml

I probably could move it somewhere else? Or have a separate repo, this seems like reasonable option right now 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. A repo name starting with a dot is a bit confusing 🙂

with:
description: ${{ github.event.pull_request.body }}
15 changes: 15 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,18 @@ repos:
args:
- https://github.com/packit/specfile.git
stages: [manual, push]
- repo: https://github.com/python-jsonschema/check-jsonschema
rev: 0.28.0
hooks:
- id: check-github-workflows
args: ["--verbose"]
- repo: https://github.com/Lucas-C/pre-commit-hooks
rev: v1.5.5
hooks:
- id: insert-license
files: \.py$
args:
- --license-filepath
- LICENSE_HEADER.txt
- --comment-style
- "#"
2 changes: 2 additions & 0 deletions LICENSE_HEADER.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Copyright Contributors to the Packit project.
SPDX-License-Identifier: MIT
3 changes: 3 additions & 0 deletions docs/api/processors.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Copyright Contributors to the Packit project.
# SPDX-License-Identifier: MIT

import dataclasses
import re
from typing import List, Optional
Expand Down
3 changes: 3 additions & 0 deletions plans/git_reference.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#!/usr/bin/python

# Copyright Contributors to the Packit project.
# SPDX-License-Identifier: MIT

import subprocess
from pathlib import Path

Expand Down
Loading