Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant coverage checks in CI #353

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ajjackson
Copy link
Collaborator

Closes #352

We only really need to use coverage for one pass over the test suite, and only on the ubuntu runner (as this is the one that uploads the coverage results.)

We only really need to use coverage for one pass over the test
suite, and only on the ubuntu runner (as this is the one that uploads
the coverage results.)
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Results

   18 files  ±  0     18 suites  ±0   56m 53s ⏱️ - 5m 3s
1 066 tests ±  0  1 060 ✅ ±  0   6 💤 ±0  0 ❌ ±0 
8 564 runs   - 748  8 512 ✅  - 747  52 💤  - 1  0 ❌ ±0 

Results for commit d94f10e. ± Comparison against base commit a00bbfa.

♻️ This comment has been updated with latest results.

We are hitting some rate-limiting, v4 with token should help with
that. It is also supposed to allow fork PRs to push coverage without a
token, although that is subject to rate-limiting.

The rate limit seems to be across all github projects using codecov,
which is why it fires off pretty frequently.
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.43%. Comparing base (1f3f8c0) to head (d94f10e).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files          29       29           
  Lines        4209     4209           
  Branches      641      641           
=======================================
  Hits         4017     4017           
  Misses        114      114           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajjackson ajjackson marked this pull request as ready for review January 6, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only check coverage on ubuntu runs
1 participant