Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unintended nameof type piracy #328

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Remove unintended nameof type piracy #328

merged 3 commits into from
Dec 12, 2024

Conversation

pablosanjose
Copy link
Owner

@pablosanjose pablosanjose commented Dec 12, 2024

Closes #327

The reason for #327 was an obscure problem with stdlib Serialization caused by the following methods

Base.nameof(::Type{<:OrbitalSliceMatrix}) = "OrbitalSliceMatrix"
Base.nameof(::Type{<:OrbitalSliceVector}) = "OrbitalSliceVector"
Base.nameof(::Type{<:CompressedOrbitalMatrix}) = "CompressedOrbitalMatrix"

It might not seem at first sight, but this is a rookie mistake: those are doing pretty terrible nameof piracy (even though OrbitalSliceArray etc. are all property of Quantica), and were causing all sort of havoc, particularly in Distributed calculations (which relies on Serialization, which mysteriously choked due to the above)

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.31%. Comparing base (6197b8b) to head (c8339a1).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/show.jl 40.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   92.47%   92.31%   -0.16%     
==========================================
  Files          39       39              
  Lines        6907     7001      +94     
==========================================
+ Hits         6387     6463      +76     
- Misses        520      538      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablosanjose pablosanjose merged commit f64e499 into master Dec 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with Distributed since #323
2 participants