Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration path override in densitymatrix and josephson #309

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

pablosanjose
Copy link
Owner

@pablosanjose pablosanjose commented Oct 7, 2024

When creating a ρ = densitymatrix(gs, ωpoints; kw...) or J = josephson(gs, ωpoints; kw...) object using the generic integration algorithm, one specifies the integration path through ωpoints (see #307 ). However, it may be necessary to override the shape of the path as a function of parameters or temperature, for example, which are not known until we actually evaluate the object with ρ(µ, kBT; params...) or J(kBT; params...). For this reason we provide here an advance call syntax

ρ(µ, kBT, override = missing; params...)
J(kBT, override = missing; params...)

where override can be a collection of ωpoints that replace the original ωpoints, or a function that is applied to them before integration. For technical reasons the override syntax is currently only supported if the original ωpoints are not all real (since in that case a different sawtooth transform takes place as per the docstrings)

@pablosanjose pablosanjose changed the title Integration path override to densitymatrix and josephson Integration path override in densitymatrix and josephson Oct 7, 2024
better error message

fix
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.03%. Comparing base (3d52e7f) to head (db5011b).

Files with missing lines Patch % Lines
src/observables.jl 90.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   93.05%   93.03%   -0.02%     
==========================================
  Files          38       38              
  Lines        6548     6560      +12     
==========================================
+ Hits         6093     6103      +10     
- Misses        455      457       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablosanjose pablosanjose merged commit d9d751d into master Oct 7, 2024
9 checks passed
pablosanjose added a commit that referenced this pull request Oct 8, 2024
pablosanjose added a commit that referenced this pull request Oct 8, 2024
@pablosanjose pablosanjose deleted the override branch October 25, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants