Merge pull request #211 from pablosanjose/allow_empty_sublats

Allow empty sublats
pablosanjose · Oct 12, 2023 · b06c4ad · b06c4ad
2 parents 5e085d8 + e238812
commit b06c4ad
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 9 deletions.
diff --git a/docs/src/tutorial/observables.md b/docs/src/tutorial/observables.md
@@ -93,9 +93,10 @@ julia> f = Figure(); a = Axis(f[1,1], xlabel = "ω/t", ylabel = "T(ω)"); lines!
 ```@raw html
 <img src="../../assets/four_terminal_T.png" alt="Total transmission from right contact" width="400" class="center"/>
 ```
+So we indeed find that the 90-degree transmission `T₃₁` is indeed larger than the forward transmission `T₂₁` for all energies. The rapid oscillations are due to mesoscopic fluctuations.
 
 !!! note "Total transmission vs transmission probability"
-    Note that `transmission` gives the total transmission, which is the sum of the transmission probability from each orbital in the source contact to any other orbital in the drain contact. As such it is not normalized to 1, but to the number of source orbitals. It also gives the local conductance from a given contact in units of $$e^2/h$$ according to the Landauer formula, $$G\_j = e^2/h \sum_i T_{ij}(eV)$$.
+    Note that `transmission` gives the total transmission, which is the sum of the transmission probability from each orbital in the source contact to any other orbital in the drain contact. As such it is not normalized to 1, but to the number of source orbitals. It also gives the local conductance from a given contact in units of $$e^2/h$$ according to the Landauer formula, $$G_j = e^2/h \sum_i T_{ij}(eV)$$.
 
 ## Conductance
 

diff --git a/src/docstrings.jl b/src/docstrings.jl
@@ -1726,6 +1726,7 @@ dω ∑ⱼ [fᵢ(ω) - fⱼ(ω)] Gᵢⱼ(ω)``, where ``fᵢ(ω)`` is the Fermi
 
 Compute the conductance at the specified contacts.
 
+# Examples
 ```jldoctest
 julia> # A central system g0 with two 1D leads and transparent contacts
 

diff --git a/src/types.jl b/src/types.jl
@@ -5,10 +5,6 @@
 struct Sublat{T<:AbstractFloat,E}
     sites::Vector{SVector{E,T}}
     name::Symbol
-    function Sublat{T,E}(sites, name) where {T<:AbstractFloat,E}
-        isempty(sites) && argerror("Sublattices cannot be empty")
-        return new(sites, name)
-    end
 end
 
 struct Unitcell{T<:AbstractFloat,E}
@@ -41,8 +37,6 @@ end
 
 #region ## Constructors ##
 
-Sublat(sites::Vector{SVector{E,T}}, name::Symbol) where {T,E} = Sublat{T,E}(sites, name)
-
 Bravais(::Type{T}, E, m) where {T} = Bravais(T, Val(E), m)
 Bravais(::Type{T}, ::Val{E}, m::Tuple{}) where {T,E} =
     Bravais{T,E,0}(sanitize_Matrix(T, E, ()))

diff --git a/test/test_greenfunction.jl b/test/test_greenfunction.jl
@@ -22,7 +22,7 @@ function testgreen(h, s; kw...)
     return nothing
 end
 
-@testset "bare greenfunctions" begin
+@testset "basic greenfunctions" begin
     h0 = LP.honeycomb() |> hamiltonian(hopping(SA[0 1; 1 0]), orbitals = 2) |> supercell(region = RP.circle(10))
     s0 = GS.SparseLU()
     h1 = LP.square() |> hamiltonian(@onsite((; o = 1) -> o*I) + hopping(SA[0 1; 1 0]), orbitals = 2) |> supercell((1,0), region = r -> abs(r[2]) < 2)
@@ -66,6 +66,9 @@ end
             testgreen(oh, s)
         end
     end
+    # contacts that don't include all sublattices
+    h = lattice(sublat(0, name = :L), sublat(1, name = :R)) |> hamiltonian
+    @test h |> attach(onsite(ω->1), sublats = :L) |> greenfunction isa GreenFunction
 end
 
 @testset "greenfunction KPM" begin

diff --git a/test/test_lattice.jl b/test/test_lattice.jl
@@ -31,7 +31,7 @@ end
     end
     @test sublat((3,)) isa Sublat{Float64,1}
     @test sublat(()) isa Sublat{Float64,0}
-    @test_throws ArgumentError sublat(SVector{3,Float64}[])
+    @test sublat(SVector{3,Float64}[]) isa Sublat{Float64,3}
 end
 
 @testset "lattice construction" begin

diff --git a/test/test_plots.jl b/test/test_plots.jl
@@ -1,3 +1,5 @@
+@test_throws ArgumentError qplot(LP.linear())  # no backend loaded
+
 using CairoMakie
 
 @testset "plot lattice" begin