fix jitter behaviour of skia due to double buffers swapping #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tushar5526 <[email protected]>
Co-authored-by: tushar5526 <[email protected]>
This was referenced Nov 17, 2023
Weird jittery behavior when
background() is not called in draw() while using the skia renderer.
#425
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realted to #424 #425
The jittery behaviour and errors with skia were due to wrong rendering logic. GLFW uses a double buffer swapping technique to render graphics and our logic was only running the new commands and the previous state was getting lost after buffer swaps.
Currently did a hacky solution to fix it for now (tested on MacOS)
surfacein an image before flushing and swapping the buffers. The state is then restored before the start of the next frame.pathin Canvas, which I don't think is easy to do with the current code structure.TODO: to switch to using
bitmaporpixmapto store stateThis PR also fixes the errors of wrong mouse position in retina displays on MAC.