Channel splitting #13
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Tibo-lg
force-pushed
the
split-tx-experiment
branch
3 times, most recently
from
e0dfa30 to
91a5eec
Compare
Tibo-lg
force-pushed
the
split-tx-experiment
branch
from
91a5eec to
017121f
Compare
The (de)serialisation for `ChannelTransactionParameters` changed between 0.0.114 and 0.0.116. This type had already been modified by us when adding the `original_funding_outpoint` field. When first introduced, we chose a type value of 14. After the update, we chose to reduce it down to 12 since the type 12 was no longer being used after changes between 0.0.114 and 0.0.116. Unfortunately, this unnecessarily broke channels created before the update. Eventually we will need to settle on a way to handle these possible conflicts with upstream. Tibo already suggested a few options: - Use much larger numbers for `rust-dlc` custom fields. - Move LDK values around as we rebase on top of new changes. - Add a subdomain for `rust-dlc` custom fields.
Tibo-lg
force-pushed
the
split-tx-experiment
branch
from
017121f to
3274833
Compare
It would be even nicer to log the `ChannelDetails`, but then we would have to modify the macro and that is too painful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.