-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved configuration API with TOML file #519
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## announcements #519 +/- ##
=================================================
+ Coverage 92.16% 92.34% +0.17%
=================================================
Files 101 102 +1
Lines 16079 16063 -16
=================================================
+ Hits 14820 14834 +14
+ Misses 1259 1229 -30
☔ View full report in Codecov by Sentry. |
I'm not going to police the language in anyone's code, but some teams I'm in have moved away from the whitelist/blacklist terminology to allowlist/denylist |
All really helpful feedback, thank you! Agree with that weird terminology. |
872b0c4
to
d51304f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really great to me, I had a suggestion around being able to configure your node to not support any schema ids.
Am i correct understanding that the default for a node without any custom configurations is that it is "ephemeral" (no db or identity state is persisted)?
Thanks for your comments @jadehopepunk all really useful! |
* main: Announce supported schema ids in network before replication (#515)
Closes #511, #513, #516, #510
📋 Checklist
Add tests that cover your changesCHANGELOG.md