Bunch of changes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the build context. The build context really is only about building the app, while finish-args is about running it.
and reset it to the state of the CRDT. This can muss up the cursor but at least we're not back on track and won't diverge. Also, print a warning. Should probably be something user visible though.
We now connect to the TextBuffer signal directly.
swick
force-pushed
the
wip/bunch-of-changes
branch
from
ec019a2 to
381e3f6
Compare
|
Rebased and (hopefully) fixed the macOS CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly wanted to implement the check to make sure the CRDT and text view have the same state. Added support for toasts to show the user a message and then started cleaning up the code a bit...