Discover and subscribe to documents based on short code #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreae
changed the title
sandreae
commented
Dec 27, 2024
| while let Some(message) = rx.recv().await { | ||
| match message { | ||
| ToApp::NewDocument(text_document) => { | ||
| // @TODO: get the short code for this document into the share UI |
There was a problem hiding this comment.
Need to load a new document into the UI here. This event occurs when the app starts, and also after a preceding request from the frontend to subscribe to a document based on it's short code.
There was a problem hiding this comment.
Another approach (maybe nicer) for this messaging channel would be to still only have one message variant, but always include the document id as well as the message bytes. Then when a change in document id is detected we interpret this as a change of document.
Doesn't change anything about how the frontend would react, just how this change is communicated to the front end.
sandreae
commented
Dec 27, 2024
aardvark-app/src/window.rs
Outdated
| @@ -67,6 +67,8 @@ mod imp { | |||
| let window = self.obj().clone(); | |||
| let dialog = self.open_document_dialog.clone(); | |||
| self.open_document_button.connect_clicked(move |_| { | |||
| // @TODO: Send `FromApp::Subscribe` message to network containing the share code | |||
There was a problem hiding this comment.
Need to send the short code to the backend here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the logic required for discovering documents by their short code and then subscribing to them. To do this we introduce a new "document discovery" overlay network which allows peers to resolve a short code to the full document topic (which can then be used for subscribing to document events).
AardvarkTopicwhich has one variant for document discovery, and one for document message gossip and syncShortCodebased on theTextDocumenthashTextDocumentto contain the public key of the author who created it and a timestampNodestruct which wraps all networking and persistence objects and exposes new API forTODO
TextDocumentin the app/UI