OZ-684: Odoo FHIR facade implementation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibacher
approved these changes
Sep 12, 2024
|
Code looks good. I assume the build failure is addressable (seems to be a renamed package or something?) |
Yes, I need to publish the underlying library |
wluyima
reviewed
Sep 23, 2024
fhir-odoo-mapper/src/main/java/com/ozonehis/fhir/odoo/OdooConstants.java
Show resolved
Hide resolved
wluyima
reviewed
Sep 23, 2024
fhir-odoo-mapper/src/main/java/com/ozonehis/fhir/odoo/mappers/ChargeItemDefinitionMapper.java
Outdated
Show resolved
Hide resolved
wluyima
reviewed
Sep 23, 2024
| * | ||
| * @return an array of field names annotated with {@link JsonProperty} | ||
| */ | ||
| public String[] fields() { |
There was a problem hiding this comment.
Isn't their utilities in spring or apache beanutils that do this?
There was a problem hiding this comment.
No, this is different because it looks for fields annotated with @JsonProperty and picks the value. This is because the field in the response might be different from the class field name.
wluyima
reviewed
Sep 23, 2024
fhir-odoo/src/main/java/com/ozonehis/fhir/odoo/SessionHolder.java
Outdated
Show resolved
Hide resolved
wluyima
reviewed
Sep 23, 2024
...o/src/main/java/com/ozonehis/fhir/odoo/chargeItemDefinition/ChargeItemDefinitionService.java
Show resolved
Hide resolved
wluyima
reviewed
Sep 23, 2024
fhir-odoo/src/main/java/com/ozonehis/fhir/odoo/inventoryItem/InventoryItemService.java
Show resolved
Hide resolved
wluyima
suggested changes
Sep 23, 2024
corneliouzbett
force-pushed
the
OZ-684
branch
from
77a08c4 to
be20228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://mekomsolutions.atlassian.net/browse/OZ-684
This PR implements a FHIR API for Odoo. It uses
odoo-java-apilibrary to interact with Odoo backend.