Improve handling of name collisions between parameters and top-level body fields #941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In oxidecomputer/oxide.rs#853 we had a situation where a parameter (query) had the same name as a top-level field in the POST body. In this case, we prioritized the body field over the parameter. This led to the CLI subcommand being unusable. While this particular case turned out to be a mistake in the API, if such a situation were to occur, this PR causes us to ignore the body field (thus making the body required if the field was required).
This PR has a commit that introduces the new test for this condition and then a commit that contains the fix.