-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pinned maghemite #5726
Update pinned maghemite #5726
Conversation
I'm not totally confident there isn't a step I've missed in this; if @rcgoodfellow or others have things to point out, I'm all ears. |
Heh just caught this. It would be nice if either this mismatch could be caught in CI and/or it was easier to make the change. Lines 563 to 567 in 4dda5cb
|
Since it seems like https://gist.github.com/david-crespo/d8aa7ea1afb877ff585e6ad90fc5bc2c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. Ultimately it would be nice to get rid of these environment variable files and just use what's in Cargo.toml.
The pinned sha for maghemite was out of date, pointing to an invalid sha (I believe because of some force pushes that removed the specific commit).
This updates omicron to point to the most recent sha for maghemite and updates the necessary checksums so the tests pass.
Some context on why this is even needed: because there is no mac build of mgd, we build it from source for macs, and need the correct sha for that.