Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESM support #69

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add ESM support #69

wants to merge 7 commits into from

Conversation

zephraph
Copy link
Contributor

@zephraph zephraph commented Feb 22, 2024

This PR updates the tsup configuration to generate esm builds.

📦 Published PR as canary version: 1.3.0--canary.69.6b085bb.0

✨ Test out this PR locally via:

npm install @oxide/[email protected]
# or 
yarn add @oxide/[email protected]

@zephraph zephraph added the minor Increment the minor version when merged label Feb 22, 2024
@david-crespo
Copy link
Collaborator

wat

image

@zephraph
Copy link
Contributor Author

I'm looking into it.

@zephraph
Copy link
Contributor Author

Auto bug is fixed. There was an issue with a new version of git but that was fixed upstream.

@david-crespo
Copy link
Collaborator

Tried it in docs and there may be one more change required around CSS. Or it could be a change required on the docs side. Here's the import.

vite v5.1.4 building for production...
✓ 56 modules transformed.
x Build failed in 171ms
Error: [vite:css] [postcss] Missing "./styles/dist/main.css" specifier in "@oxide/design-system" package
file: /Users/david/oxide/docs/app/styles/index.css?transform-only:undefined:NaN
    at e (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47384:25)
    at n (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47384:627)
    at o (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47384:1297)
    at resolveExportsOrImports (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:48061:20)
    at resolveDeepImport (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:48080:31)
    at tryNodeResolve (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47805:20)
    at Context.resolveId (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47568:28)
    at Object.resolveId (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:50762:64)
    at async Object.<anonymous> (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:67768:21)
    at async Object.resolve (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:31933:34) {
  code: 'PLUGIN_ERROR',
  loc: { file: undefined, line: undefined, column: NaN },
  pluginCode: "@import '@oxide/design-system/styles/dist/main.css';\n" +
    "@import '@oxide/design-system/styles/dist/yellow.css';\n" +
    "@import '@oxide/design-system/styles/dist/purple.css';\n" +
    "@import '@oxide/design-system/styles/dist/green.css';\n" +
    "@import '@oxide/design-system/styles/dist/blue.css';\n" +
    "@import '@oxide/design-system/components/dist/asciidoc.css';\n" +

// etc etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants