Fix loading bar to handle longer requests, god forbid #1670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1657. Two main changes:
animation-fill-mode: forwards
to make the bar sit in place when it runs out of time instead of resetting to 0loading
part of the animation from 1.5s to 4s, adjusting the % location of the keyframes to make it so it looks the same as before for short requests, but for longer ones can spend a bit more time creeping forward rather than sitting stillThe video is too long, I did not feel like editing out the useless parts.
main
with fast request (good)main
with 2000ms request (bad, bar disappears at 1.5s, reappears for whoosh done animation)whoosh
out)loading-bar.mp4