Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License files (eslint-plugin-header) #1665

Closed
wants to merge 1 commit into from
Closed

Conversation

david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Jul 16, 2023

I wanted to put this up here, but I kind of hate this plugin:

  • In --fix mode, it stomps on any existing comment at the top of a file, even an eslint-disable that actually needs to be there
  • For some reason it hates a blank line between the comment and the code. This produces distasteful results.

Since I have what I think is a decent set of file include/exclude globs (which was the hard part) I will either rewrite this by hand as a safety test (already got a start on this last week) and/or try one of the other plugins people have made.

@vercel
Copy link

vercel bot commented Jul 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Jul 16, 2023 8:23pm

@@ -0,0 +1,39 @@
import { assertType, test } from 'vitest'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the extension on this file and put the asserts inside of a test so this could be excluded along with all other *.spec.ts

@david-crespo david-crespo deleted the license-header-plugin branch July 17, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant