Add ability to create image from snapshot #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There's a somewhat larger track of work here which is making the image creation form match the designs. Currently it's completely upload centric whereas the designs show being able to pick a source (upload, snapshot, and potentially URL). I haven't decided if I'm going to take that piece of work on or defer it for later. |
zephraph
commented
Jul 15, 2023
| @@ -313,6 +314,12 @@ export const routes = createRoutesFromElements( | |||
| element={<CreateSnapshotSideModalForm />} | |||
| handle={{ crumb: 'New snapshot' }} | |||
| /> | |||
| <Route | |||
| path="snapshots/:snapshot/image-new" | |||
There was a problem hiding this comment.
The path here is a little odd. I've patterned it after the other create endpoints though it doesn't necessarily need to be image-new. It could be something like create-image. There's really just no precedent for that.
There was a problem hiding this comment.
I think this is the most reasonable choice.
david-crespo
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1456
This PR enables creating an image from a snapshot in the snapshots list page.
Tasks
Follow-up
There's some remaining work to be done here, but after thinking about it a bit I've decided to pull it out of this PR to contain the scope. When creating an image from the image list page instead of an action that says
Upload imageit should sayNew image(similarly to how projects, instances, etc are listed). We should then add an image source selector to mirror the API which should offer a choice between snapshot and upload.(Note the designs show disk which isn't valid in this case)