Merge pull request #212 from Quasilyte/quasilyte/sloppyLen

realize: don't guard against negative length
oxequa · Sep 18, 2018 · bcf8507 · bcf8507
2 parents c046dff + 1a7c6b7
commit bcf8507
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/realize.go b/realize.go
@@ -1135,7 +1135,7 @@ func start(c *cli.Context) (err error) {
 
 	}
 	// check project list length
-	if len(r.Schema.Projects) <= 0 {
+	if len(r.Schema.Projects) == 0 {
 		// create a new project based on given params
 		project := r.Schema.New(c)
 		// Add to projects list

diff --git a/realize/cli_test.go b/realize/cli_test.go
@@ -44,7 +44,7 @@ func TestRealize_Prefix(t *testing.T) {
 	r := Realize{}
 	input := "test"
 	result := r.Prefix(input)
-	if len(result) <= 0 && !strings.Contains(result, input) {
+	if len(result) == 0 && !strings.Contains(result, input) {
 		t.Error("Unexpected error")
 	}
 }

diff --git a/realize/projects.go b/realize/projects.go
@@ -343,7 +343,7 @@ L:
 
 // Validate a file path
 func (p *Project) Validate(path string, fcheck bool) bool {
-	if len(path) <= 0 {
+	if len(path) == 0 {
 		return false
 	}
 	// check if skip hidden

diff --git a/realize_test.go b/realize_test.go
@@ -56,7 +56,7 @@ func TestRealize_add(t *testing.T) {
 	if err := m.add(); err != nil {
 		t.Error("Unexpected error")
 	}
-	if len(m.Projects) <= 0 {
+	if len(m.Projects) == 0 {
 		t.Error("Unexpected error")
 	}