Quick fix crash

oxen-io · Mar 8, 2021 · 234f5eb · 234f5eb
1 parent a17f327
commit 234f5eb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/Session/Conversations/ConversationVC.swift b/Session/Conversations/ConversationVC.swift
@@ -148,7 +148,6 @@ final class ConversationVC : BaseVC, ConversationViewModelDelegate, OWSConversat
         Storage.read { transaction in
             unreadCount = self.thread.unreadMessageCount(transaction: transaction)
         }
-        // FIXME: This crashes when you have more unread messages than loaded view items (viewItems is initially capped to kConversationInitialMaxRangeSize)
         unreadViewItems = unreadCount != 0 ? [ConversationViewItem](viewItems[viewItems.endIndex - Int(unreadCount) ..< viewItems.endIndex]) : []
     }
 

diff --git a/Session/Conversations/ConversationViewModel.m b/Session/Conversations/ConversationViewModel.m
@@ -173,7 +173,7 @@ + (ConversationUpdate *)diffUpdateWithUpdateItems:(nullable NSArray<Conversation
 static const int kYapDatabasePageSize = 100;
 
 // Never show more than n messages in conversation view when user arrives.
-static const int kConversationInitialMaxRangeSize = 300;
+static const int kConversationInitialMaxRangeSize = 25000; // TODO: Does it cause issues to set this so high?
 
 // Never show more than n messages in conversation view at a time.
 static const int kYapDatabaseRangeMaxLength = 25000;