Apply minimum exit time to regular exits #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same minimum 2 hour limit that applies to liquidation should apply to regular exits. See comments in oxen-io/oxen-core#1750 for more details.
The signature verification code in these two functions is virtually identical now (there was some slight optimization that had been applied to one of these but not the other, but is functionally identical).
jagerman
force-pushed
the
exit-restrictions
branch
from
29bca90
to
80220c0
Compare
We should require that a leave request has been initiated before accepting an exit with signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same minimum 2 hour limit that applies to liquidation should apply to regular exits. See comments in oxen-io/oxen-core#1750 for more details.
This also extracts the substantially duplicate code between the public exit and liquidate with signature functions into a private function.
Edit: + requires a leave request has been made before allowing a regular, signed exit.