Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast, parser)!: remove NumericLiteral::new method #6787

Open
wants to merge 1 commit into
base: 10-22-refactor_ast_parser_transformer_traverse_remove_bindingidentifier_new_methods
Choose a base branch
from

Conversation

overlookmotel
Copy link
Collaborator

No description provided.

Copy link

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel changed the title refactor(ast, parser): remove NumericLiteral::new method refactor(ast, parser)!: remove NumericLiteral::new method Oct 22, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 22, 2024 17:06
@github-actions github-actions bot added A-parser Area - Parser A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 22, 2024
Copy link

codspeed-hq bot commented Oct 22, 2024

CodSpeed Performance Report

Merging #6787 will create unknown performance changes

Comparing 10-22-refactor_ast_parser_remove_numericliteral_new_method (edacb11) with 10-22-refactor_ast_parser_transformer_traverse_remove_bindingidentifier_new_methods (37fc1ca)

Summary

🆕 30 new benchmarks

Benchmarks breakdown

Benchmark 10-22-refactor_ast_parser_transformer_traverse_remove_bindingidentifier_new_methods 10-22-refactor_ast_parser_remove_numericliteral_new_method Change
🆕 codegen[checker.ts] N/A 27.3 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 80.1 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 399 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 24 µs N/A
🆕 lexer[antd.js] N/A 22.4 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.3 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.4 ms N/A
🆕 linter[cal.com.tsx] N/A 1 s N/A
🆕 linter[checker.ts] N/A 2.5 s N/A
🆕 minifier[antd.js] N/A 426.4 ms N/A
🆕 minifier[react.development.js] N/A 2.9 ms N/A
🆕 minifier[typescript.js] N/A 520.3 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 78.3 µs N/A
🆕 parser[antd.js] N/A 107.2 ms N/A
🆕 parser[cal.com.tsx] N/A 24.7 ms N/A
🆕 parser[checker.ts] N/A 53.6 ms N/A
🆕 parser[pdf.mjs] N/A 17.5 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 97.6 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant