Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): minify conditions with de Morgan's law. #6698

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Oct 20, 2024

This is a optimization only applied in Closure Compiler.

Copy link

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

7086cmd commented Oct 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @7086cmd and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Oct 20, 2024
@7086cmd 7086cmd force-pushed the 10-20-feat_minifier_minify_conditions_with_de_morgan_s_law branch from 580e53e to c51a842 Compare October 20, 2024 04:29
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6698 will degrade performances by 43.69%

Comparing 10-20-feat_minifier_minify_conditions_with_de_morgan_s_law (c51a842) with main (01a35bb)

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 10-20-feat_minifier_minify_conditions_with_de_morgan_s_law Change
minifier[typescript.js] 520.5 ms 924.3 ms -43.69%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant