Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/typescript): insert assignments after super by StatementInjector #6654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 18, 2024

No description provided.

Copy link

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Oct 18, 2024

@Dunqing Dunqing changed the title refactor(transformer/typescript): insert assignments after super by StatementInjector refactor(transformer/typescript): insert assignments after super by StatementInjector Oct 18, 2024
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 18, 2024
Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #6654 will not alter performance

Comparing 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector (a19027f) with main (b711ee1)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 10-18-feat_transformer_introduce_statementinjector_helper branch from b170471 to 2270e72 Compare October 21, 2024 10:51
@overlookmotel overlookmotel force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch from ca8c578 to 2b616a1 Compare October 21, 2024 10:52
@Dunqing Dunqing force-pushed the 10-18-feat_transformer_introduce_statementinjector_helper branch from b051f24 to 7fbca9d Compare October 21, 2024 11:00
Base automatically changed from 10-18-feat_transformer_introduce_statementinjector_helper to main October 21, 2024 11:04
@Dunqing Dunqing force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch 2 times, most recently from 3e01750 to e51e2fe Compare October 21, 2024 11:11
@overlookmotel
Copy link
Collaborator

bench Nice!

@Dunqing
Copy link
Member Author

Dunqing commented Oct 21, 2024

bench Nice!

Why I can't see the performance improvement in this PR

@Boshen Boshen marked this pull request as ready for review October 22, 2024 09:41
@Dunqing Dunqing force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch from 38df391 to 1a894aa Compare October 22, 2024 13:38
@Dunqing Dunqing changed the base branch from main to 10-22-fix_transformer_after_using_statementinjector_some_statements_disappeared October 22, 2024 13:38
@overlookmotel overlookmotel changed the base branch from 10-22-fix_transformer_after_using_statementinjector_some_statements_disappeared to graphite-base/6654 October 22, 2024 14:10
@overlookmotel overlookmotel force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch from 1a894aa to 03f0cf2 Compare October 22, 2024 14:14
@overlookmotel overlookmotel changed the base branch from graphite-base/6654 to main October 22, 2024 14:15
@overlookmotel overlookmotel force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch from 03f0cf2 to a19027f Compare October 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants