feat(ast-tools): generalize strict_if into flags_if

[DonIsaac]

No description provided.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[DonIsaac]

• feat(semantic): add ScopeFlags::Ambient #6592
• feat(ast-tools): generalize strict_if into flags_if #6591 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

[overlookmotel]

Sorry to say, I'm not keen on this. I think strict_if(self.is_strict()) is much clearer than flags_if(ScopeFlags::StrictMode, self.is_strict()).

Additionally, what flags_if does is unclear unless you delve into the implementation. e.g. this:

#[scope(
    flags(ScopeFlags::TsModuleBlock),
    flags_if(ScopeFlags::Ambient, self.declare),
)]

Does it mean:

1. If self.declare is true, flags are ScopeFlags::Ambient? or
2. If self.declare is true, flags are ScopeFlags::TsModuleBlock | ScopeFlags::Ambient?

If the motivation is #6592, could you not do this instead?

#[scope(
    flags(ScopeFlags::TsModuleBlock.with_ambient(self.declare))
)]

[codspeed-hq]

CodSpeed Performance Report

Merging #6591 will not alter performance

_{Comparing don/10-14-feat_ast-tools_generalize_strict_if_into_flags_if (4dbfaf9) with main (7a028b3)}

Summary

✅ 30 untouched benchmarks