Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): support --print-config all to print config file for project #6579

Conversation

mysteryven
Copy link
Member

@mysteryven mysteryven commented Oct 15, 2024

Continue work on #4742.

Only oxlint --print-config all is supported. It's useful to migrate from command-line interface to config file.

The --print-config PATH looks not really useful for us now, I will add it after config file overrides supported.

Copy link

graphite-app bot commented Oct 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-enhancement Category - New feature or request labels Oct 15, 2024
Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #6579 will not alter performance

Comparing 10-15-feat_linter_support_--print-config_all_to_print_config_file_for_project (0acca58) with main (ffa3945)

Summary

✅ 30 untouched benchmarks

@mysteryven mysteryven force-pushed the 10-15-feat_linter_support_--print-config_all_to_print_config_file_for_project branch from d9b0ae4 to dbfbad6 Compare October 15, 2024 13:21
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mysteryven and the rest of your teammates on Graphite Graphite

@Boshen Boshen requested a review from DonIsaac October 15, 2024 13:41
@pumano
Copy link
Contributor

pumano commented Oct 15, 2024

very useful feature for debugging!

apps/oxlint/src/lint/mod.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/lib.rs Outdated Show resolved Hide resolved
@mysteryven mysteryven force-pushed the 10-15-feat_linter_support_--print-config_all_to_print_config_file_for_project branch 2 times, most recently from 3ea0e38 to a49952f Compare October 18, 2024 00:16
@mysteryven mysteryven force-pushed the 10-15-feat_linter_support_--print-config_all_to_print_config_file_for_project branch from a49952f to 837f12c Compare October 18, 2024 00:18
@Boshen Boshen self-assigned this Oct 20, 2024
apps/oxlint/src/command/mod.rs Outdated Show resolved Hide resolved
apps/oxlint/src/command/mod.rs Outdated Show resolved Hide resolved
@Boshen Boshen assigned mysteryven and unassigned Boshen Oct 21, 2024
@mysteryven mysteryven force-pushed the 10-15-feat_linter_support_--print-config_all_to_print_config_file_for_project branch 2 times, most recently from 2b047d3 to 829b51d Compare October 22, 2024 12:27
@DonIsaac
Copy link
Collaborator

LGMT

@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Oct 22, 2024
Copy link
Collaborator

DonIsaac commented Oct 22, 2024

Merge activity

  • Oct 22, 1:55 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 22, 1:55 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 22, 2:00 PM EDT: A user merged this pull request with the Graphite merge queue.

…roject (#6579)

Continue work on #4742.

Only `oxlint --print-config all` is supported. It's useful to migrate from command-line interface to config file.

The `--print-config PATH` looks not really useful for us now, I will add it after config file overrides supported.
@DonIsaac DonIsaac force-pushed the 10-15-feat_linter_support_--print-config_all_to_print_config_file_for_project branch from 829b51d to 0acca58 Compare October 22, 2024 17:56
@graphite-app graphite-app bot merged commit 0acca58 into main Oct 22, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-15-feat_linter_support_--print-config_all_to_print_config_file_for_project branch October 22, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants