fix(isolated_declarations): Don't require private method arguments to have type annotations

[MichaelMitchell-at]

In #4934 I introduced a regression which caused the following code to begin having an isolated declarations error where it shouldn't:

export class Foo {
  private foo(a): void {}
}

TS playground

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[MichaelMitchell-at]

This is a little bit hacky. I think a less hacky way might be to decouple methods like transform_formal_parameters from generating errors and then move the check for errors after this block, but I wanted to get some feedback before starting to attempt something like that.

[Dunqing]

I think we can handle the private method early, can you try it?

[codspeed-hq]

CodSpeed Performance Report

Merging #5874 will not alter performance

_{Comparing MichaelMitchell-at:allow_private_method_arg_missing_type (a1ce91c) with main (1ccf290)}

Summary

✅ 29 untouched benchmarks

[Dunqing]

Sorry, I didn't see any errors in your case.

The private method will turn into a property without type annotations. The output is

export class Foo {
  private foo;
}

[MichaelMitchell-at]

Sorry, I didn't see any errors in your case.

The private method will turn into a property without type annotations.

That's the correct behavior, but currently there is an error when using oxc_isolated_declarations. This PR removes the error. If you pull this branch locally and undo the change I made to class.rs, the snapshot test will begin to fail.

[Dunqing]

That's the correct behavior, but currently there is an error when using oxc_isolated_declarations. This PR removes the error. If you pull this branch locally and undo the change I made to class.rs, the snapshot test will begin to fail.

Ah, you are right. I found our example that doesn't report any isolated declaration errors. Fixes in #5918

[Dunqing]

Fixed in #5964

We are about to release a new version that includes fixes for many incorrect outputs in oxc-isolated-declarations, as well as support for the strip_internal option. Therefore, I will fix all known bugs before the next release. Thank you for trying to fix it.

[MichaelMitchell-at]

Thank you!