Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled buttons #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

h-banii
Copy link

@h-banii h-banii commented Jan 28, 2024

Fixes #120

image

Copy link

vercel bot commented Jan 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sakura ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2024 9:55am

@h-banii
Copy link
Author

h-banii commented Jan 28, 2024

Another thing I noticed is that index.html is missing the "File input" field that is present in test.html, not sure if that was on purpose or an accident, just making sure...

I can add it to index.html if necessary, since this PR is somewhat related to the file input button. It might be good to add a "Disabled file input" as well.

@earlAchromatic
Copy link
Contributor

Oh, just came here to make this PR. Glad to see it's already being taken care of!

@oxalorg
Copy link
Owner

oxalorg commented Nov 18, 2024

Hey @h-banii really appreciate your PR! Sorry I've taken long to get back to this, but the reason I did not merge this PR is the usage of advanced sass functions like at-root. My goal with sakura was to make it very easy to read for folks who are new to web development.

I feel I already failed to do that by writing it in sass and may get rid of it someday. Regardless I don't want to complicate the nesting structure at the moment. Do you think you could implement this in a way without at-root? I know it's been too long and too late for this response of mine and apologies for that so if you've already moved on from this project I'd be happy to make those changes myself!

Thanks and cheers! 🌸

@h-banii
Copy link
Author

h-banii commented Nov 19, 2024

@oxalorg , no problem! Yes, I can do it without at-root for sure

I'll make a commit when I get some free time (near friday/saturday)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled buttons are not displayed correctly
3 participants