-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add actions into the embed mode #9841
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
89bc142
to
f5f775d
Compare
@JammingBen @dschmidt ping for review 🙏 |
I had to update snapshots due to the change in files wrapper... the change is kept in a separate commit to spot it more easily |
packages/web-app-files/src/components/EmbedActions/EmbedActions.vue
Outdated
Show resolved
Hide resolved
The test failure is strange... the test passes when the portal in files wrapper is commented out but looking in the code, I do not see anything that would be causing recurring calls. |
Found it together with Jannik... we need to stub out the portal component as it seems to cause troubles in tests. We are not testing portal itself in those tests so it is fine to stub it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
You probably need to stub portal
in GenericTrash.spec.ts
as well for the unit tests to go green.
You're right, thanks!... it should pass now |
Kudos, SonarCloud Quality Gate passed! |
feat: add actions into the embed mode
Description
Add Cancel, Share and Select action into the files app available only when the mode is set to embed. All actions are ported below the app container.
Related Issue
Motivation and Context
These new actions allow external developers to consume resources or links from within the embedded web ui.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: