Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make openidconnect in oC10 possible #5536

Merged
merged 2 commits into from
Jul 21, 2021
Merged

make openidconnect in oC10 possible #5536

merged 2 commits into from
Jul 21, 2021

Conversation

wkloucek
Copy link
Contributor

Description

One can currently not use ownCloud Web with ownCloud 10 and OpenID connect, because proper content policies are missing and calls to the OIDC provider will fail.

Related Issue

  • none

Motivation and Context

The oCIS migration strategy requires to run ownCloud 10 with OIDC and Web. This is currently not possible.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/17477/10/1
The following scenarios passed on retry:

  • webUISharingAcceptShares/acceptShares.feature:109

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/17477/39/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a bugfix changelog item please? I think I missed that for the onlyoffice and richdocuments CSP rules myself, but would be nice to have one here. :-) code looks good to me, thanks for taking care! 💪🏻

Copy link
Member

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/17482/39/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@wkloucek
Copy link
Contributor Author

@fschade you're right OIDC should be part of the Documentation https://owncloud.dev/clients/web/deployments/oc10-app/. Only oAuth is mentioned there until now

@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pascalwengerter
Copy link
Contributor

I'd love to get this merged and would try to release a v3.4.2 (= bugfix only release) in web early next week and even ship that one with the OC10.8 release if possible?

@wkloucek
Copy link
Contributor Author

I'd love to get this merged and would try to release a v3.4.2 (= bugfix only release) in web early next week and even ship that one with the OC10.8 release if possible?

for me that would be fine. But would need coordination with @micbar

@kulmann
Copy link
Member

kulmann commented Jul 19, 2021

@wkloucek do you want to add documentation to this PR or add that in a separate PR? I'd be fine merging this and adding docs in a separate PR.

@wkloucek wkloucek merged commit ae68efe into master Jul 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the oc10_openid_connect branch July 21, 2021 15:33
@wkloucek
Copy link
Contributor Author

I'll open a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants