add owncloud-selector cookie support #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
butonic
force-pushed
the
set-selector-cookie
branch
4 times, most recently
from
302f949
to
3d5148f
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
set-selector-cookie
branch
from
3d5148f
to
c8692f9
Compare
|
Kudos, SonarCloud Quality Gate passed! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the live migration we are reading a claim from the openid connect userinfo to set the
owncloud-selectorcookie that the proxy uses to route requests to ocis or oc10.The response we need to react to is the redirect from the IdP which looks like
https://cloud.ocis.test/apps/openidconnect/redirect?code=fooberbazrandombytes&scope=openid%20profile%20email&session_state=some.jwt.token%3D&state=somethingThere is no Authorization Bearer header set, yet so we cannot set the cookie in the proxy. For now, the best place to put the code is the openidconnect app.