Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] listing permission with role Space Editor Without Version enabled #10380

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Oct 22, 2024

Description

This PR adds test for listing permission with role Space Editor Without Version enabled

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Oct 22, 2024
@nirajacharya2 nirajacharya2 force-pushed the test-space-no-versions-list-permission branch 4 times, most recently from 77f387f to 29cb76d Compare October 28, 2024 08:16
@nirajacharya2 nirajacharya2 force-pushed the test-space-no-versions-list-permission branch 2 times, most recently from c935764 to cec1fc5 Compare October 29, 2024 05:02
@nirajacharya2 nirajacharya2 force-pushed the test-space-no-versions-list-permission branch from cec1fc5 to 743a932 Compare October 30, 2024 03:46
Copy link

sonarcloud bot commented Oct 30, 2024

@nirajacharya2 nirajacharya2 marked this pull request as ready for review October 30, 2024 05:41
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci] Test space no versions list permission [tests-only][full-ci] listing permission with role Space Editor Without Version enabled Oct 31, 2024
"""


Scenario: user lists permissions of a folder in personal space after enabling 'Space Editor Without Versions' role
Copy link
Member

@saw-jan saw-jan Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tole is for sharing space not a folder. hmm, should the role be listed for folder as well?

CC @ScharfViktor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, scenario title is misleading.

Suggested change
Scenario: user lists permissions of a folder in personal space after enabling 'Space Editor Without Versions' role
Scenario: user lists permissions of a space after enabling 'Space Editor Without Versions' role

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants