Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Thumbnails for GGP files #10304

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Oct 15, 2024

@kobergj kobergj force-pushed the BumpReva branch 2 times, most recently from 24e5198 to bdf6154 Compare October 16, 2024 07:04
@kulmann
Copy link
Member

kulmann commented Oct 16, 2024

@kobergj do you have an example file available?

@kobergj
Copy link
Collaborator Author

kobergj commented Oct 16, 2024

Unfortunately not. I requested one though. PR on hold.

@kobergj kobergj marked this pull request as draft October 16, 2024 08:28
@kulmann
Copy link
Member

kulmann commented Oct 16, 2024

Unfortunately not. I requested one though. PR on hold.

Cool. We need a PR to web similar to this: https://github.com/owncloud/web/pull/11583/files
The list of previewable mimetypes is hardcoded in web (because there is no good server mechanism and we can't request thumbnails for each and every file)

@kulmann
Copy link
Member

kulmann commented Oct 29, 2024

@kobergj do you plan to get this in for ocis 7.0? I made a PR in web so that .ggp previews get requested (result in a 404 at the moment). See owncloud/web#11829 - I'd revert it if it won't be part of ocis 7.0.

@kobergj
Copy link
Collaborator Author

kobergj commented Oct 29, 2024

@kulmann Thanks! Would be cool if it could make 7.0. I also have an example file now, so we can test.

@rhafer
Copy link
Contributor

rhafer commented Oct 29, 2024

I also have an example file now, so we can test.

Can we add that to the repo ( services/thumbnails/testdata) similar to the ggs file?

@kobergj
Copy link
Collaborator Author

kobergj commented Nov 4, 2024

@rhafer I added the file

@kulmann can we merge the web PR? Then it is easier for me to test (and fix) it.

Copy link

sonarcloud bot commented Nov 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants