Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Remove OcisHelper class and its references #40629

Merged
merged 2 commits into from
Feb 10, 2023
Merged

[tests-only][full-ci] Remove OcisHelper class and its references #40629

merged 2 commits into from
Feb 10, 2023

Conversation

roshanlc
Copy link

Description

This PR removes OcisHelper.php and its references in the tests base. It is a part of API acceptance cleanup.
Any other OCIS related functions will be removed subsequently

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@roshanlc roshanlc marked this pull request as ready for review February 10, 2023 05:32
@SwikritiT SwikritiT mentioned this pull request Feb 10, 2023
Open
11 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@roshanlc roshanlc mentioned this pull request Feb 10, 2023
Merged
11 tasks
@phil-davis phil-davis merged commit 21002f0 into owncloud:master Feb 10, 2023
@roshanlc roshanlc deleted the remove-ocis-helper-class branch February 10, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@roshanlc roshanlc

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roshanlc @phil-davis @SwikritiT