Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Remove isTestingOnOcisOrReva() method and its references #40628

Merged
merged 2 commits into from
Feb 9, 2023
Merged

[tests-only][full-ci] Remove isTestingOnOcisOrReva() method and its references #40628

merged 2 commits into from
Feb 9, 2023

Conversation

roshanlc
Copy link

@roshanlc roshanlc commented Feb 9, 2023 •
edited
Loading

Description

This PR removes method isTestingOnOcisOrReva() and its references from tests codebase as a part of API acceptance tests cleanup.

Other Ocis related helper functions will be removed in later PRs.

Related Issue

Part of
#40572

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.0% 66.0% Coverage
0.0% 0.0% Duplication

@roshanlc roshanlc marked this pull request as ready for review February 9, 2023 10:41
saw-jan
saw-jan reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👍

SagarGi
SagarGi reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@phil-davis phil-davis merged commit fdb9fb0 into owncloud:master Feb 9, 2023
@roshanlc roshanlc deleted the remove-reva-or-ocis-conditional branch February 10, 2023 03:40
@SwikritiT SwikritiT mentioned this pull request Feb 10, 2023
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@roshanlc roshanlc

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roshanlc @phil-davis @SagarGi @saw-jan @SwikritiT