Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Acceptance tests to export the local storages mounts to a file #37123

Merged
merged 4 commits into from
Mar 18, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Mar 13, 2020

Description

Add acceptance tests to export the local storages mounts to a file

Related Issue

#36704
#37054

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #37123 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37123   +/-   ##
=========================================
  Coverage     64.78%   64.78%           
  Complexity    19130    19130           
=========================================
  Files          1267     1267           
  Lines         74911    74912    +1     
  Branches       1328     1328           
=========================================
+ Hits          48532    48533    +1     
  Misses        25989    25989           
  Partials        390      390           
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.96% <ø> (+<0.01%) 19130.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Connector/Sabre/SharesPlugin.php 96.29% <0.00%> (+0.06%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8c8e7...03db91e. Read the comment docs.

@jasson99 jasson99 requested a review from dpakach March 17, 2020 04:42
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis phil-davis merged commit 534023d into master Mar 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the files-external-imports branch March 18, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants