Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Pin behat/mink to version 1.7.1 #37112

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 12, 2020

Description

New versions of MinkSelenium2Driver and Mink were released overnight. Our Behat acceptance tests vendor-bin/Behat/composer.json automagically sucks in the new changes. And "stuff failed" (see the issue for details).

https://github.com/minkphp/MinkSelenium2Driver/releases/tag/v1.4.0
https://github.com/minkphp/Mink/releases/tag/v1.8.1

MinkSelenium2Driver 1.4.0 is working fine. So we can use that rather than relying on dev-master - good.

But Mink 1.8.0 or 1.8.1 causes the problem. It might be related to minkphp/Mink#705 which changed the way that sessions get started (e.g. to selenium) - I will look at that later. For now, specify Mink 1.7.1 to get things working. (dependencies in other Behat-Mink things were causing later Mink code to get loaded)

Related Issue

How Has This Been Tested?

Local acceptance test run and CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@1314c83). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37112   +/-   ##
=========================================
  Coverage          ?   64.78%           
  Complexity        ?    19133           
=========================================
  Files             ?     1270           
  Lines             ?    74914           
  Branches          ?     1328           
=========================================
  Hits              ?    48531           
  Misses            ?    25993           
  Partials          ?      390
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (?) 0 <ø> (?)
#phpunit 65.96% <ø> (?) 19133 <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1314c83...e8028ce. Read the comment docs.

@individual-it individual-it merged commit 53f348e into master Mar 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the pin-behat-mink-1.7.1 branch March 12, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants