-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-Only] Add acceptance test for translated response messages #37069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Codecov Report
@@ Coverage Diff @@
## master #37069 +/- ##
=========================================
Coverage 64.75% 64.76%
- Complexity 19135 19136 +1
=========================================
Files 1270 1270
Lines 74909 74915 +6
Branches 1329 1328 -1
=========================================
+ Hits 48511 48517 +6
- Misses 26007 26008 +1
+ Partials 391 390 -1
Continue to review full report at Codecov.
|
@dpakach please review again. This looks OK - I guess the risk is the a translator of one of these languages decides to change the translation, and then CI will suddenly break. But it will be easy to fix if it happens. Then the commits can be squashed before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use outline to test for different languages rather than repeating it every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this sort of scenario it is OK to have repeated When/Then - otherwise it takes so much time if we have 8 rows in the examples table...
drone had timeouts pulling some docker images. I restarted it. |
Description
This PR adds acceptance test for the translated error messages when the Accept-Language header is set to some preferred language.
Related Issue
owncloud/QA#608
How Has This Been Tested?
CI
Types of changes
Checklist: