[Tests-only] for files_external:list with applicable users and groups and --short #36837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I raised issue #36838 to discuss the "unexpected" output of |
phil-davis
commented
Jan 28, 2020
| | localStorage | | ||
| | local_storage2 | | ||
| | new_local_storage | | ||
| Then the following local storage should be listed: |
There was a problem hiding this comment.
I deleted the first scenario, because actually the 2nd scenario did the same thing anyway (with more output checking), and I did not see the value of the time spent to run the first scenario.
phil-davis
force-pushed
the
list-storage-applicable-groups-users
branch
from
45d24b7
to
330d667
Compare
individual-it
approved these changes
Jan 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #36837 +/- ##
=========================================
Coverage 64.69% 64.69%
Complexity 19114 19114
=========================================
Files 1269 1269
Lines 74807 74807
Branches 1327 1327
=========================================
Hits 48394 48394
Misses 26022 26022
Partials 391 391
Continue to review full report at Codecov.
|
delete-merged-branch
bot
deleted the
list-storage-applicable-groups-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add scenarios to test:
files_external:listwith local storage having "applicable users" and "applicable groups"files_external:list --shortRelated Issue
Part of #36704
How Has This Been Tested?
Local run of new test scenarios + CI
Types of changes
Checklist: