Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-only] Add acceptance test to list all created local storage using occ command #36754

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

jasson99
Copy link
Contributor

Description

Add acceptance test to list all created local storage using the command line.

Related Issue

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #36754 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36754   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19120    19120           
=========================================
  Files          1269     1269           
  Lines         74778    74778           
  Branches       1320     1320           
=========================================
  Hits          48372    48372           
  Misses        26018    26018           
  Partials        388      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (ø) 19120 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf22e5...fa7f881. Read the comment docs.

@phil-davis phil-davis changed the title Add acceptance test to list all created local storage using occ command [Tests-only] Add acceptance test to list all created local storage using occ command Jan 15, 2020
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a good start.
Then we can add scenarios for local storage with different applicable users/groups etc, and check that those are listed.

tests/acceptance/features/bootstrap/OccContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/OccContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/OccContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/OccContext.php Outdated Show resolved Hide resolved
@phil-davis phil-davis self-requested a review January 15, 2020 11:42
@owncloud owncloud deleted a comment from update-docs bot Jan 16, 2020
@phil-davis
Copy link
Contributor

We can merge this when CI passes.
@jasson99 then you can rebase the other PR about deleting local storage.
And then make a PR to add scenarios that test the other "columns" of output of files_external:list :

  • Mount Id should have a number in it
  • Storage should say "Local"
  • Authentication Type should say "None"
  • Configuration should have "datadir" with some string in it
  • Options should be empty
  • Applicable Users should be empty
  • Applicable Groups should be empty

Then make some scenarios that change the "applicable users" and/or "applicable groups" and check that the list output contains those users and/or groups.

And try files_external:list --short - that should give less output.

@phil-davis
Copy link
Contributor

Rebased just now. Maybe that will help "fix" the strange litmus CI failure.

@phil-davis phil-davis merged commit e5666c8 into master Jan 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the listLocalStorage branch January 16, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants