Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fastnbt): add network nbt to serializer #115

Merged
merged 1 commit into from
May 12, 2024
Merged

feat(fastnbt): add network nbt to serializer #115

merged 1 commit into from
May 12, 2024

Conversation

devwckd
Copy link
Contributor

@devwckd devwckd commented May 12, 2024

This PR:

  • Adds an extra param serialize_root_name to SerOpts along with helper methods.
  • Gives extra functionality to a Serializer with serialize_root_name set to false.
  • Adds a unit test to ensure it works.

Closes #114

@owengage
Copy link
Owner

Looks great, thanks. 😄

@owengage owengage merged commit 08e7abb into owengage:master May 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No network NBT option for serialization?
2 participants
@devwckd @owengage