Allow workers to continue execution if onerror is handled
#16606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/bun.js/web_worker.zig
Outdated
| WebWorker__dispatchError(globalObject, worker.cpp_worker, bun.String.createUTF8(array.slice()), error_instance); | ||
| const handled = WebWorker__dispatchError(globalObject, worker.cpp_worker, bun.String.createUTF8(array.slice()), error_instance); | ||
| if (handled) { | ||
| vm.unhandled_error_counter -= 1; |
There was a problem hiding this comment.
I'm not sure if this should be decremented
There was a problem hiding this comment.
It seemed suspect to me as well. I'll look at making a new handler instead.
There was a problem hiding this comment.
I'm not actually certain how else to do this without incrementing/decrementing whether it was handled or not. If you have thoughts, please lmk.
|
Had one comment. This does need a test before we can merge it though. |
|
@Jarred-Sumner force pushed and GitHub auto-closed by accident 🤦 New PR is here with a test added. In my testing the decrement is fine, but definitely a bit janky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16424.
The way I did this is certainly janky, and probably should not be merged in current state.
I wasn't sure how to mark the event loop alive, since the current exception handler increments unhandled errors. Maybe
onQuietUnhandledRejectionHandlerCaptureValueshould be replaced so this code is less confusing? Open to thoughts.